Pont 3 api key to constructor #11
Conversation
Add the cds_api_url and cds_api_key arguments to CDSDataOpener and use them (if supplied) when instantiating the CDS API client. To facilitate testing of this feature, add a last_instantiated_client field to CDSDataOpener and url and key fields (and corresponding constructor arguments) to CDSClientMock.
There was a problem hiding this comment.
The tests work nicely. However, I found it a bit hard to figure out the differences between the three new tests 'test_client_url_and_key_parameters', 'test_client_url_and_key_environment_variables' and 'test_client_url_and_key_rc_file'. I recommend that you at least document the tests a bit so that we know why e.g. to test the file access you pass only the client_class to the opener.
Also, it seems that the tests do not consider any preexisting environment variables and may overwrite those. This should be prevented.
Finally, I'd recommend to create a new TestClass for the new tests (e.g., ClientUrlTest) and use setUp()- and tearDown()-functions instead of the two static methods you have used.
|
@TonioF Thanks for the suggestions -- all implemented. I've put the new tests into a new |
This PR adds
cds_api_urlandcds_api_keyparameters to theCDSDataOpenerandCDSDataStoreconstructors. Previously, the CDS API URl and key could only be specified via environment variables or a configuration file.