New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support DragonFlyBSD #2

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@mneumann
Copy link
Contributor

mneumann commented Aug 6, 2016

No description provided.

@@ -15,6 +15,9 @@

#ifdef HAVE_NET_IF_H
# include <net/if.h>
#ifdef __DragonFly__

This comment has been minimized.

@dcuddeback

dcuddeback Oct 15, 2016

Owner

Is there a good reason to use this macro instead of using AC_CHECK_HEADERS() in configure.ac?

This comment has been minimized.

@mneumann

mneumann Nov 16, 2016

Contributor

Dunno how to correctly do that with AC_CHECK_HEADERS, as it only needs to be included on DragonFly.

This comment has been minimized.

@dcuddeback

dcuddeback Nov 20, 2017

Owner

@mneumann That's what autoconf takes care of. The autoconf philosophy is to test for features instead of platforms:

they do not normally even need an argument specifying the system type. Instead, they individually test for the presence of each feature that the software package they are for might need

https://www.gnu.org/software/autoconf/manual/autoconf-2.62/html_node/Introduction.html#Introduction

If you're interested, I made some commits on top of your branch that do this with AC_CHECK_HEADERS: https://github.com/dcuddeback/ioctl-rs/compare/feature/dragonfly?expand=1#diff-ecc1a87332cffa717e3a14c626ae27cbL28

@dcuddeback

This comment has been minimized.

Copy link
Owner

dcuddeback commented Oct 15, 2016

@mneumann Sorry, I missed this PR before. Thanks for submitting this.

@dcuddeback

This comment has been minimized.

Copy link
Owner

dcuddeback commented Nov 20, 2017

@mneumann I just released this in v0.1.6. I removed two of the definitions (SIOCADDRT and SIOCDELRT), because they were recently removed from DragonFly: bycn82/dfly@ac6b17f#diff-e8da22b0b71706a913abc3066e655a06

@dcuddeback

This comment has been minimized.

Copy link
Owner

dcuddeback commented Nov 20, 2017

Closing because I merged this on the command-line. @mneumann Thanks for submitting this.

@dcuddeback dcuddeback closed this Nov 20, 2017

@mneumann mneumann deleted the mneumann:fix-dragonfly branch Dec 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment