New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for DragonFlyBSD #6

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@mneumann
Copy link

mneumann commented Aug 6, 2016

Reuse the freebsd module, but export it as "dragonfly".

Add support for DragonFlyBSD
Reuse the freebsd module, but export it as "dragonfly".
@mneumann

This comment has been minimized.

Copy link

mneumann commented Jul 10, 2017

@dcuddeback Any chance to get this merged in, and a 0.2.3 release?

@dcuddeback

This comment has been minimized.

Copy link
Owner

dcuddeback commented Jul 30, 2017

@mneumann Yeah. I need to setup a VM with Dragonfly BSD to test with. I just got back from vacation, but will try to do that soon.

@mneumann

This comment has been minimized.

Copy link

mneumann commented Aug 1, 2017

@dcuddeback Cool! If you need help with setting up DragonFly, let me know. We have rust and cargo in ports, so you can install them via "pkg install rust cargo".

@dcuddeback

This comment has been minimized.

Copy link
Owner

dcuddeback commented Nov 20, 2017

@mneumann After a few false-starts, I was able to get rustc and cargo installed on DragonFly BSD 5.0. Not sure why it wasn't working for me before. I was hoping to wrap this up before flying home for Thanksgiving, but it looks like that's not going to happen. I compared freebsd.rs to the definitions in <termios.h> and found a few differences. I pushed up a branch feature/dragonfly with a new module for dragonfly. That should work. The main thing holding me back from releasing it right now is that it breaks the API in src/lib.rs, since DragonFly BSD doesn't export TAB3. I think just removing TAB3 from the reexports in src/lib.rs should be fine, which is what I did in feature/dragonfly, but I need to think about it some more before I release that. I'll bump the version to v0.2 if I do that since that's technically a breaking change.

@dcuddeback

This comment has been minimized.

Copy link
Owner

dcuddeback commented Dec 3, 2017

@mneumann Termios definitions for DragonFly are now in master, and I just released v0.3.0 to crates.io with the new definitions. Dropping TAB3 from the crate root is consistent with the goal of keeping the crate root portable, and turns out to be we did when adding FreeBSD support too (#3), so I went with that. Thanks for being patient.

@dcuddeback dcuddeback closed this Dec 3, 2017

@mneumann

This comment has been minimized.

Copy link

mneumann commented Dec 5, 2017

@dcuddeback : Thanks!

@mneumann mneumann deleted the mneumann:fix-dragonfly branch Dec 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment