New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BinaryFileManager when the width is applied image is created with gray border #25

Closed
kpmrafeeq opened this Issue Mar 27, 2017 · 6 comments

Comments

Projects
None yet
2 participants
@kpmrafeeq

kpmrafeeq commented Mar 27, 2017

This is visible when we have some white area in the image, open below image in IE then you can understand better, because in Chrom we have default black area and it cannot be visible.

test image

@ThijsBorst ThijsBorst self-assigned this Mar 27, 2017

@ThijsBorst ThijsBorst added the bug label Mar 27, 2017

@ThijsBorst

This comment has been minimized.

Show comment
Hide comment
@ThijsBorst

ThijsBorst Mar 27, 2017

Member

In which version of DD4T does this occur?

Member

ThijsBorst commented Mar 27, 2017

In which version of DD4T does this occur?

@kpmrafeeq

This comment has been minimized.

Show comment
Hide comment
@kpmrafeeq

kpmrafeeq Mar 27, 2017

It is also there in 2.1.0

kpmrafeeq commented Mar 27, 2017

It is also there in 2.1.0

@ThijsBorst

This comment has been minimized.

Show comment
Hide comment
@ThijsBorst

ThijsBorst Mar 30, 2017

Member

I can reproduce this issue. Fix is coming.

Member

ThijsBorst commented Mar 30, 2017

I can reproduce this issue. Fix is coming.

@ThijsBorst

This comment has been minimized.

Show comment
Hide comment
@ThijsBorst

ThijsBorst Mar 30, 2017

Member

The issue is fixed. I've submitted two pull requests. Waiting for review...

Member

ThijsBorst commented Mar 30, 2017

The issue is fixed. I've submitted two pull requests. Waiting for review...

@ThijsBorst ThijsBorst added this to the 2.2.1 milestone Mar 30, 2017

@ThijsBorst

This comment has been minimized.

Show comment
Hide comment
@ThijsBorst

ThijsBorst Mar 30, 2017

Member

Fixed in Core Release 2.2.3, which is available now.

Member

ThijsBorst commented Mar 30, 2017

Fixed in Core Release 2.2.3, which is available now.

@ThijsBorst ThijsBorst closed this Mar 30, 2017

@kpmrafeeq

This comment has been minimized.

Show comment
Hide comment
@kpmrafeeq

kpmrafeeq commented Mar 31, 2017

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment