Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StartXpmEditingZone does not work for linked components #48

Closed
quirijnslings opened this issue Dec 11, 2019 · 2 comments
Closed

StartXpmEditingZone does not work for linked components #48

quirijnslings opened this issue Dec 11, 2019 · 2 comments
Assignees
@quirijnslings
Labels
bug

Comments

@quirijnslings
Copy link
Member

quirijnslings commented Dec 11, 2019 •
edited
Loading

If you call StartXpmEditingZone on a model that represents a linked component (rather than a component presentation), an empty string is returned. This is a shame because Tridion allows you to edit fields inside linked components if you just add a (nested) ComponentPresentation XPM comment. The template part is simply ignored.
To solve, we need to overload the StartXpmEditingZone with a parentModel (an IViewModel which contains a component template).
@quirijnslings quirijnslings self-assigned this Dec 11, 2019
@quirijnslings
Copy link
Member Author

This problem was introduced when we fixed bug 36. It is no longer throwing an exception, but since then no XPM comment is shown at all in these cases.

@quirijnslings quirijnslings mentioned this issue Dec 11, 2019
Merged
@quirijnslings
Copy link
Member Author

Published to NuGet as DD4T.MVC4.2.2.7.103-alpha / DD4T.MVC5.2.2.7.103-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@quirijnslings quirijnslings

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@quirijnslings