Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore ability to update multiple namecheap domains #64

Merged
merged 5 commits into from Jun 6, 2019

Conversation

Projects
None yet
4 participants
@icolwell
Copy link
Contributor

commented Feb 22, 2019

This PR reverts PR #54 which removed some very useful functionality.
This PR also resolves this sourceforge bug report.

Upon investigating this issue, I found a rather confusing history behind it.
You can find a full explanation of the situation on my blog. I hope it sheds some light on the issue and saves you some time trying to sort it out.
I also intend to contact namecheap support and suggest they update their docs.

In addition to re-adding the functionality, I did a bit of formatting cleanup in the immediate area surrounding the fix. I also updated the example configuration. Let me know if you'd rather leave it as-is to shorten the diff.

@wimpunk

This comment has been minimized.

Copy link
Collaborator

commented Mar 18, 2019

Is there anyone out there who can test this? The patch looks good but I want an approve to prevent adding not working patches.

@icolwell

This comment has been minimized.

Copy link
Contributor Author

commented Mar 18, 2019

I tested it myself, but I agree, it would be best if at least one other person can verify it.
Does ddclient have a suggested testing procedure? I imagine it's tricky to reliably test ddclient since so much of its functionality depends on different DNS providers.
Whoever sets out to test it, I suggest the following method:

  1. Checkout version 3.8.3 which was proven to work with multiple namecheap domains. Edit your config and confirm multiple updates work.
  2. Checkout version 3.9.0 and see how your config fails to update all the domains (it will update 1 of them).
  3. Checkout this PR and see how it (hopefully 😄) updates multiple domains again.
@erossetto

This comment has been minimized.

Copy link

commented Apr 9, 2019

Well, I've tested the patch and it works great. Go ahead and merge this.

@dalbert2

This comment has been minimized.

Copy link

commented May 29, 2019

I have also tested the patch and it now tries all of the configured domains.

Note: for each domain, you must enter a complete protocol/server/login/password fully-qualified-hosts line:
protocol=namecheap,server=dynamicdns.park-your-domain.com, login=mylogin, password=mypassword fqdn,fqdn,fqdn

@wimpunk wimpunk merged commit e910af8 into ddclient:master Jun 6, 2019

@icolwell

This comment has been minimized.

Copy link
Contributor Author

commented Jun 7, 2019

Thanks @wimpunk! I contacted namecheap support back when I created this PR but I see their documentation is still outdated. I'll reach out to them again to try to convince them to update their docs.

@dalbert2, I was able to factor out the protocol and server configs and only specify them once at the top of the config. See my config example here. I have this style of config running on multiple servers without issue, so I'm surprised by your comment.

@icolwell icolwell deleted the icolwell:namecheap_multi_domain branch Jun 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.