-
Notifications
You must be signed in to change notification settings - Fork 796
Replaced tuples with domain names #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 18 additions & 0 deletions
18
src/main/java/io/pillopl/library/lending/dailysheet/model/ExpiredHold.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| package io.pillopl.library.lending.dailysheet.model; | ||
|
|
||
| import io.pillopl.library.catalogue.BookId; | ||
| import io.pillopl.library.lending.librarybranch.model.LibraryBranchId; | ||
| import io.pillopl.library.lending.patron.model.PatronEvent.BookHoldExpired; | ||
| import io.pillopl.library.lending.patron.model.PatronId; | ||
| import lombok.Value; | ||
|
|
||
| @Value | ||
| public class ExpiredHold { | ||
| private final BookId heldBook; | ||
| private final PatronId patron; | ||
| private final LibraryBranchId library; | ||
|
|
||
| BookHoldExpired toEvent() { | ||
| return BookHoldExpired.now(this.heldBook, this.patron, this.library); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 18 additions & 0 deletions
18
src/main/java/io/pillopl/library/lending/dailysheet/model/OverdueCheckout.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| package io.pillopl.library.lending.dailysheet.model; | ||
|
|
||
| import io.pillopl.library.catalogue.BookId; | ||
| import io.pillopl.library.lending.librarybranch.model.LibraryBranchId; | ||
| import io.pillopl.library.lending.patron.model.PatronEvent.OverdueCheckoutRegistered; | ||
| import io.pillopl.library.lending.patron.model.PatronId; | ||
| import lombok.Value; | ||
|
|
||
| @Value | ||
| public class OverdueCheckout { | ||
| private final BookId checkedOutBook; | ||
| private final PatronId patron; | ||
| private final LibraryBranchId library; | ||
|
|
||
| OverdueCheckoutRegistered toEvent() { | ||
| return OverdueCheckoutRegistered.now(this.patron, this.checkedOutBook, this.library); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 15 additions & 0 deletions
15
src/main/java/io/pillopl/library/lending/patronprofile/model/Checkout.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| package io.pillopl.library.lending.patronprofile.model; | ||
|
|
||
| import io.pillopl.library.catalogue.BookId; | ||
| import lombok.Value; | ||
|
|
||
| import java.time.Instant; | ||
|
|
||
| @Value | ||
| public class Checkout { | ||
|
|
||
| private final BookId book; | ||
|
|
||
| private final Instant till; | ||
|
|
||
| } |
6 changes: 1 addition & 5 deletions
6
src/main/java/io/pillopl/library/lending/patronprofile/model/CheckoutsView.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,13 @@ | ||
| package io.pillopl.library.lending.patronprofile.model; | ||
|
|
||
| import io.pillopl.library.catalogue.BookId; | ||
| import io.vavr.Tuple2; | ||
| import io.vavr.collection.List; | ||
| import lombok.NonNull; | ||
| import lombok.Value; | ||
|
|
||
| import java.time.Instant; | ||
|
|
||
| @Value | ||
| public class CheckoutsView { | ||
|
|
||
| @NonNull | ||
| List<Tuple2<BookId, Instant>> currentCheckouts; | ||
| List<Checkout> currentCheckouts; | ||
|
|
||
| } |
15 changes: 15 additions & 0 deletions
15
src/main/java/io/pillopl/library/lending/patronprofile/model/Hold.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| package io.pillopl.library.lending.patronprofile.model; | ||
|
|
||
| import io.pillopl.library.catalogue.BookId; | ||
| import lombok.Value; | ||
|
|
||
| import java.time.Instant; | ||
|
|
||
| @Value | ||
| public class Hold { | ||
|
|
||
| private final BookId book; | ||
|
|
||
| private final Instant till; | ||
|
|
||
| } |
6 changes: 1 addition & 5 deletions
6
src/main/java/io/pillopl/library/lending/patronprofile/model/HoldsView.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,13 @@ | ||
| package io.pillopl.library.lending.patronprofile.model; | ||
|
|
||
| import io.pillopl.library.catalogue.BookId; | ||
| import io.vavr.Tuple2; | ||
| import io.vavr.collection.List; | ||
| import lombok.NonNull; | ||
| import lombok.Value; | ||
|
|
||
| import java.time.Instant; | ||
|
|
||
| @Value | ||
| public class HoldsView { | ||
|
|
||
| @NonNull | ||
| List<Tuple2<BookId, Instant>> currentHolds; | ||
| List<Hold> currentHolds; | ||
|
|
||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you revert changes in imports? In all of the files?