fix: create empty composer.json if it does not exist#160
Conversation
Check for existence of composer.json before creating it.
rfay
left a comment
rfay
left a comment
There was a problem hiding this comment.
Seems like a great idea to me.
Could you say a little bit about how often there's no composer.json in a Drupal contrib project?
|
Re-running tests. Failure seems to have been upgraded sysbox/docker |
|
I guess the tests are not set up to be useful on forked PRs. I've granted you privileges to create a PR on ddev/coder-ddev, could you push the branch there and recreate the PR? Thanks! |
|
Actually, I deployed it to staging-coder.ddev.com and manually tested, and it seemed fine, so I pulled it. Next time, PR on the upstream. Please check https://staging-coder.ddev.com with this example and a normal test and if you think it's fine I'll deploy to coder.ddev.com |
|
Just tested on https://staging-coder.ddev.com and was able to create a functional workspace as well. Thanks! |
|
Thanks @codebymikey - I pushed it to coder.ddev.com, please check there to make sure that both this one and a normal contrib one with a composer.json work fine for you. |
2 participants
Check for existence of composer.json before creating it.
The Issue #159
How This PR Solves The Issue
Creates the composer.json file if it does not exist.
Manual Testing Instructions
Attempt to create an issue fork for https://www.drupal.org/project/config_update/issues/3174327
Automated Testing Overview
N/A
Related Issue Link(s)
Release/Deployment Notes