Permalink
Commits on Mar 7, 2012
  1. Make Aphlict client somewhat more approachable

    epriestley committed Mar 7, 2012
    Summary: Provide a reasonable JS API for the Aphlict client. Provide an example behavior to invoke it.
    
    Test Plan:
    Ran "aphlict_server.js" with:
    
      $ sudo node aphlict_server.js
    
    Loaded /aphlict/. Opened console. Got "hello" from the server every second.
    
    Got reasonable errors with the server not present ("Security exception", but this is because it can't connect to port 843 to access the policy server).
    
    Reviewers: ddfisher, keebuhm, allenjohnashton, btrahan
    
    Reviewed By: btrahan
    
    CC: aran, epriestley
    
    Maniphest Tasks: T944
    
    Differential Revision: https://secure.phabricator.com/D1800
  2. Use a join instead of an awkward, weird query in PhabricatorAuditList…

    epriestley committed Mar 7, 2012
    …Controller
    
    Summary:
      - Use a join to effect this query.
      - Fixes a bug where packages with no commits would raise an exception because of the awkward query construction.
      - Fixes a bug on audit views.
    
    Test Plan:
      - Viewed a package with no commits.
      - Altered audit filters.
    
    Reviewers: btrahan, 20after4
    
    Reviewed By: 20after4
    
    CC: aran, epriestley
    
    Maniphest Tasks: T904
    
    Differential Revision: https://secure.phabricator.com/D1801
  3. Use "whitespace: pre-wrap" for <tt> text in Remarkup

    epriestley committed Mar 7, 2012
    Summary:
    I typed (tilde) (space) (space) (space) (space) (space) (tilde) earlier but it just vanishes, make it do what I intended.
    
    Also fix a missing space that was breaking a CSS rule (in h1), set it to the intended value, and remove redundant margins (h1..h6).
    
    Test Plan: Put some spaces in tildes, made some headers.
    
    Reviewers: vrana, btrahan
    
    Reviewed By: vrana
    
    CC: aran, epriestley
    
    Differential Revision: https://secure.phabricator.com/D1803
  4. Build valid HTML in Edit Maniphest Tasks

    vrana committed Mar 7, 2012
    Test Plan: Click on Edit Maniphest Tasks.
    
    Reviewers: epriestley
    
    Reviewed By: epriestley
    
    CC: aran, epriestley
    
    Differential Revision: https://secure.phabricator.com/D1802
  5. Add filter for abandoned revisions

    vrana committed Mar 7, 2012
    Test Plan: /differential/filter/reviews/?status=abandoned
    
    Reviewers: epriestley
    
    Reviewed By: epriestley
    
    CC: aran, epriestley
    
    Maniphest Tasks: T767
    
    Differential Revision: https://secure.phabricator.com/D1799
Commits on Mar 6, 2012
  1. Support /differential/filter/<filter>/<username>/

    vrana committed Mar 6, 2012
    Summary: NOTE: I didn't add BC for ?phid=.
    
    Test Plan:
    /differential/
    /differential/filter/active/
    /differential/filter/active/epriestley/
    /differential/filter/active/x/ - 404
    /differential/filter/revisions/?status=open - search for epriestley
    /differential/filter/revisions/epriestley/?status=open
    /p/jakubv/
    
    Reviewers: epriestley, nh
    
    Reviewed By: epriestley
    
    CC: aran, epriestley
    
    Maniphest Tasks: T900
    
    Differential Revision: https://secure.phabricator.com/D1797
  2. Provide an audit.query method for Conduit

    epriestley committed Mar 6, 2012
    Summary: Conduit access for open audits.
    
    Test Plan: Used test console to run some queries.
    
    Reviewers: btrahan
    
    Reviewed By: btrahan
    
    CC: aran, epriestley
    
    Maniphest Tasks: T904
    
    Differential Revision: https://secure.phabricator.com/D1792
  3. Add an "Auditors" field to commit messages which pushes audit request…

    epriestley committed Mar 6, 2012
    …s when present
    
    Summary:
    Adds an optional "Auditors" field (like "Reviewers") to commit messages which gives installs a zero-config method for making audit requests.
    
    This field does not appear on templates unless set, and is mostly ignored (but validated and preserved) by Differential.
    
    It is then parsed by the daemons if present, and audit requests are pushed to valid users.
    
    Test Plan: Made an "Auditors" commit and verified it was retained with "arc amend --show". Pushed it and verified the audit was triggered.
    
    Reviewers: btrahan
    
    Reviewed By: btrahan
    
    CC: aran, epriestley
    
    Maniphest Tasks: T904, T880
    
    Differential Revision: https://secure.phabricator.com/D1793
  4. Add a script to close all open audits in a repository

    epriestley committed Mar 6, 2012
    Summary: If you import a repository you may trigger a large number of irrelevant audits. Provide a tool to nuke them.
    
    Test Plan: Ran "audit.php Q" (does not exist), "audit.php P" (phabricator) from various repository states.
    
    Reviewers: btrahan
    
    Reviewed By: btrahan
    
    CC: aran, epriestley
    
    Maniphest Tasks: T904, T940
    
    Differential Revision: https://secure.phabricator.com/D1791
  5. Improve rendering for Maniphest custom fields

    epriestley committed Mar 6, 2012
    Summary: We render these in a realtively unreadable way right now; allow customization and provide reasonable defaults.
    
    Test Plan: Looked at some tasks with custom fields on them.
    
    Reviewers: btrahan
    
    Reviewed By: btrahan
    
    CC: aran, epriestley
    
    Maniphest Tasks: T930
    
    Differential Revision: https://secure.phabricator.com/D1790
  6. Change inline edit comment confirm button caption to Ready

    vrana committed Mar 6, 2012
    Summary:
    Caption Submit is quite confusing because it doesn't actually make the data visible to other users.
    Especially when comment confirm button is also called Submit in serious mode.
    
    Test Plan: Add inline comment.
    
    Reviewers: epriestley
    
    Reviewed By: epriestley
    
    CC: aran, epriestley
    
    Differential Revision: https://secure.phabricator.com/D1796
  7. Change All Search Boxes into Jump Navs

    ddfisher committed with epriestley Mar 6, 2012
    Summary:
    - all search boxes are now jump navs (old functionality retained if none
      of the jump nav patterns match)
    - added global keyboard shortcut '/' to focus the search box in the upper
      right
    
    Test Plan:
    - pressed '/' and noticed the search box gains keyboard focus
    - triggered jump nav functionality from search box and saw it worked
    - did a search which did not match a jump nav pattern and saw it worked
      (and searched in the selected context)
    NOTE: The search box on the /search/ page is also changed to have jump
    nav functionality. Old functionality is not impared. Still, this may not
    be desirable.
    
    Reviewers: epriestley, btrahan
    
    Reviewed By: epriestley
    
    CC: aran, epriestley
    
    Differential Revision: https://secure.phabricator.com/D1794
Commits on Mar 5, 2012
  1. Provide upgrade script for transition away from Meta MTA daemon

    Nick Harper committed Mar 5, 2012
    Summary:
    When switching from using the MetaMTADaemon to a Taskmaster for sending mail,
    if there are messages queued for delivery, they need to be re-queued into the
    task system. This patch does that.
    
    Task ID: #
    
    Blame Rev:
    
    Test Plan:
    Ran it.
    
    Revert Plan:
    
    Tags:
    
    Reviewers: epriestley, btrahan, jungejason
    
    Reviewed By: epriestley
    
    CC: aran, epriestley
    
    Differential Revision: https://secure.phabricator.com/D1780
  2. Maniphest CSS changes

    epriestley committed Mar 5, 2012
    Summary:
      - Remove "0.5%" padding which makes Safari flip out and render every row differently sometimes.
      - Remove list padding from ManiphestTaskListView, put it in the controller composition instead.
    
    Test Plan: Viewed all places where task lists appear.
    
    Reviewers: btrahan
    
    Reviewed By: btrahan
    
    CC: aran, epriestley
    
    Differential Revision: https://secure.phabricator.com/D1788
  3. Some maniphest / aphront form UI tweaks

    bobtrahan committed Mar 5, 2012
    Summary:
    Just a few random things I wanted to tweak...
    
    - Maniphest homepage tasks box has less padding so it vertically aligns with other "stuff" boxes
    - Made form <h1> have more padding
    
    Test Plan:
    - Looked at Maniphest on the homepage -- looks good!
    - Looked at Maniphest Task List
    - " Batch Edit
    - Looked at a view other form places like Herald rules and Repository edit - looks good
    
    Reviewers: epriestley
    
    Reviewed By: epriestley
    
    CC: aran, epriestley
    
    Differential Revision: https://secure.phabricator.com/D1776
  4. Respect Status and Order in Filter Revisions

    vrana committed Mar 4, 2012
    Summary:
    Filter Revisions button currently resets Status and Order fields.
    I've rewritten it to GET form because it doesn't perform any action.
    It fixed the problem along the way.
    
    Test Plan:
    /differential/filter/revisions/
    Status: Open.
    Filter Revisions.
    
    Reviewers: epriestley
    
    Reviewed By: epriestley
    
    CC: aran, epriestley
    
    Differential Revision: https://secure.phabricator.com/D1771
  5. Fix OAuth Client Authorization bugs

    bobtrahan committed Mar 5, 2012
    Summary: ajtrichards reported an error creating a brand new authorization. fixed that and generally made this flow work well
    
    Test Plan:
    - created a fresh test client
    -- noted "new=<PHID>" with appropriate highlighting
    - visited http://phabricator.dev/oauthserver/auth/?client_id=PHID-OASC-jwgdrqdpzomtxyg3q3yf&response_type=code&scope=offline_access
    -- clicked "cancel", verified result
    -- clicked "approve", verfied result
    - visited http://phabricator.dev/oauthserver/auth/?client_id=PHID-OASC-jwgdrqdpzomtxyg3q3yf&response_type=code&scope=whoami
    -- noted got the dialog
    -- noted that it had the union of desired and existing so user could update it properly! (NB - its up to the client to react to whatever specific scope(s) the user decides to grant)
    -- noted it actually updated when I hit "approve"
    
    Reviewers: epriestley, ajtrichards
    
    Reviewed By: epriestley
    
    CC: aran, epriestley
    
    Maniphest Tasks: T933
    
    Differential Revision: https://secure.phabricator.com/D1775
  6. Migrate "PhabricatorOwnersPackageCommitRelationship" to "PhabricatorR…

    epriestley committed Mar 5, 2012
    …epositoryAuditRequest"
    
    Summary:
      - Move table to Repository, since we have no Owners joins in the application anymore but would like to do a Repository join.
      - Rename "packagePHID" to "auditorPHID", since this column may contain package, project, or user PHIDs.
    
    Test Plan:
      - Browsed Owners, Audit, and Differential interfaces to the Audit tool.
      - Made comments and state changes.
      - Ran "reparse.php --herald --owners" on several commits.
    
    Reviewers: btrahan, jungejason
    
    Reviewed By: btrahan
    
    CC: aran, epriestley, nh, vrana
    
    Maniphest Tasks: T904
    
    Differential Revision: https://secure.phabricator.com/D1787
  7. Improve error message when user encounters a table/column schema error

    epriestley committed Mar 5, 2012
    Summary: These are because they forgot to upgrade_schema.php like 99% of the time.
    
    Test Plan: Hit such an error, got a better error message than before.
    
    Reviewers: btrahan, jungejason
    
    Reviewed By: jungejason
    
    CC: aran, epriestley
    
    Differential Revision: https://secure.phabricator.com/D1786
  8. Add retry count to meta mta view

    Nick Harper committed Mar 5, 2012
    Summary:
    Show the retry count in the meta mta view (in addition to the list of
    messages) - I find this info useful when I'm trying to debug what's going on
    with mail failures.
    
    Task ID: #
    
    Blame Rev:
    
    Test Plan:
    loaded /mail/view/NNNNN/ and saw the retry count
    
    Revert Plan:
    
    Tags:
    
    Reviewers: epriestley, btrahan, jungejason
    
    Reviewed By: epriestley
    
    CC: aran, epriestley
    
    Differential Revision: https://secure.phabricator.com/D1782
  9. Provide a way to view MetaMTA messages by status

    Nick Harper committed Mar 5, 2012
    Summary:
    Added a query option of status for the MetaMTA list controller. There currently
    isn't a ui for accessing this.
    
    Task ID: #
    
    Blame Rev:
    
    Test Plan:
    loaded /mail/, /mail/?status=queued, /mail?phid=PHID...&status=...
    each request returned a sane list of data
    
    Revert Plan:
    
    Tags:
    
    Reviewers: epriestley, btrahan, jungejason
    
    Reviewed By: epriestley
    
    CC: aran, epriestley
    
    Differential Revision: https://secure.phabricator.com/D1784
  10. Revert rP87c60abbd02d, apply D1772

    vrana committed Mar 5, 2012
    Test Plan:
    Apply SQL patch.
    Visit /differential/.
    
    Reviewers: epriestley
    
    Reviewed By: epriestley
    
    CC: aran, epriestley
    
    Differential Revision: https://secure.phabricator.com/D1781
  11. Support ` for delimiting monospaced text in Remarkup

    vrana committed Mar 4, 2012
    Summary: Update ducks for D1773.
    
    Test Plan: Remarkup_Reference.html
    
    Reviewers: epriestley
    
    Reviewed By: epriestley
    
    CC: aran, epriestley
    
    Differential Revision: https://secure.phabricator.com/D1774
  12. Display Reviewed By instead of first Reviewer in revisions overview

    vrana committed Mar 4, 2012
    Summary:
    Displaying reviewer who was by coincidence listed first is quite confusing, especially for committed revisions.
    This displays the one who really reviewed the revision if available.
    
    This implementation is pretty bad from performance perspective - O(N) queries to retrieve all comments.
    The page load still feels quite fast.
    
    Test Plan: /differential/filter/revisions/
    
    Reviewers: epriestley
    
    CC: aran, epriestley
    
    Differential Revision: https://secure.phabricator.com/D1772
  13. Simplify Owners interfaces to Audit

    epriestley committed Mar 5, 2012
    Summary:
      - Owners has "by user" commit views, but these are supplanted by the Audit views. Just nuke them.
      - Owners has "by package" commit views; consolidate these onto the package detail pages and link into Audit for full details.
    
    Test Plan: Browsed all the Owners interfaces, clicked "View All ... Commits" buttons.
    
    Reviewers: btrahan, jungejason
    
    Reviewed By: btrahan
    
    CC: aran, epriestley
    
    Maniphest Tasks: T904
    
    Differential Revision: https://secure.phabricator.com/D1764
  14. Automatically select the right Conduit URI path for the irc bot

    epriestley committed Mar 5, 2012
    Summary: The docs say "http://www.domain.com/" but if you don't put "/api/" it fails. GOTCHA!
    
    Test Plan: Removed "/api/", launched bot, it worked.
    
    Reviewers: btrahan
    
    Reviewed By: btrahan
    
    CC: aran, epriestley
    
    Maniphest Tasks: T935
    
    Differential Revision: https://secure.phabricator.com/D1763
  15. Make Diffusion Herald emails thread with Audit emails

    epriestley committed Mar 5, 2012
    Summary:
      - Users may elect to receive an initial notification about a commit; allow it to be replied to in order to interact with the object.
      - Share thread headers between emails.
      - Add the "REPLY HANDLER ACTIONS" section to both emails.
    
    Test Plan:
      - Used "reparse.php --herald" to trigger herald emails, verified reply-to and email body.
      - Made audit comments, verified body.
    
    Reviewers: btrahan
    
    Reviewed By: btrahan
    
    CC: aran, epriestley
    
    Maniphest Tasks: T904
    
    Differential Revision: https://secure.phabricator.com/D1762
Commits on Mar 4, 2012