/ddnet

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when copying multiple layers to another map #1452

Closed
def- opened this Issue Feb 10, 2019 · 2 comments

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@def- @trikiman
@def-
Copy link
Member

def- commented Feb 10, 2019

As reported here: https://forum.ddnet.tw/viewtopic.php?t=6747

If u trying copy all game tiles (swither, tele,game itc ) with hold shift, then load map , then if u trying paste switch and speedup,client will be crashed, if u trying paste tele it is just no pasted.
ps ddclient 11.7.2

@bojidar-bg Could you take a look?

bojidar-bg added a commit to bojidar-bg/ddnet that referenced this issue Feb 11, 2019

@bojidar-bg
Fix crash when painting tiles from a non-switch to a switch layer 
Fixes ddnet#1452.
Verified
This commit was signed with a verified signature.
@bojidar-bg bojidar-bg Bojidar Marinov
GPG key ID: 4D546A8F1E091856 Learn about signing commits
352157d

@bojidar-bg bojidar-bg referenced this issue Feb 11, 2019

Merged

Fix crash when painting tiles from a non-switch to a switch layer #1454

bors bot added a commit that referenced this issue Feb 11, 2019

@bors @bojidar-bg
Merge #1454 
1454: Fix crash when painting tiles from a non-switch to a switch layer r=def- a=bojidar-bg

Fixes #1452.

Not sure if this is the best possible way to fix the issue.

Co-authored-by: Bojidar Marinov <bojidar.marinov.bg@gmail.com>
Loading status checks…
e5ad9a2

@def- def- closed this in #1454 Feb 11, 2019

@trikiman

This comment has been minimized.

Sign in to view
Copy link

trikiman commented Feb 15, 2019

What about tele,switch itc ? this not copy at other map.
@trikiman

This comment has been minimized.

Sign in to view
Copy link

trikiman commented Feb 15, 2019 •
edited

trying copy from https://forum.ddnet.tw/download/file.php?id=38330 to https://forum.ddnet.tw/download/file.php?id=38332
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment