Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Multi-line chat messages sometimes overlay the next chat message #687

Closed
d3fault opened this issue Mar 17, 2017 · 6 comments
Labels

Comments

@d3fault
Copy link

@d3fault d3fault commented Mar 17, 2017

I haven't seen this bug at all until the past week or two. I'm too lazy to figure out which commit introduced the bug. As you can see from the screenshots, chat lines are sometimes covering other chat lines.

I'm on a Debian Jessie amd64 box running the latest commit ( 1257648 )

screenshot - 03142017 - 01 31 32 am
screenshot - 03172017 - 01 13 18 pm

@Learath2

This comment has been minimized.

Copy link
Contributor

@Learath2 Learath2 commented Mar 18, 2017

My fault :( 3bd94b9 is probably to blame.

@necropotame necropotame added the todo label Mar 20, 2017
@def- def- closed this in 2849e23 Mar 22, 2017
def- added a commit that referenced this issue Mar 22, 2017
Fix line width. Closes #687
@d3fault

This comment has been minimized.

Copy link
Author

@d3fault d3fault commented Apr 3, 2017

@Learath2
Seems mostly fixed as of 2849e23 but it's still bugged for votes (note: the map name and f3 reason can't be too short OR too long, Bl0odDens3 called via /map is the right length to trigger the bug):
vote over chat
edit: I guess the length of the vote caller's name factors in as well and must be the perfect length xD

@Learath2 Learath2 reopened this Apr 3, 2017
@Learath2

This comment has been minimized.

Copy link
Contributor

@Learath2 Learath2 commented Apr 3, 2017

@def- also reported an occurrence of this on IRC.

I don't see anything else wrong tho.

@d3fault

This comment has been minimized.

Copy link
Author

@d3fault d3fault commented Apr 7, 2017

Here's another, this time not a vote. 2849e23 did seem to make it appear less often, and I think every time I see it now it only overflows a little bit on the left.

asdf

@d3fault

This comment has been minimized.

Copy link
Author

@d3fault d3fault commented Apr 7, 2017

Disabling client IDs changes it so you need a few more chars to trigger the bug.
asdf2

@Learath2

This comment has been minimized.

Copy link
Contributor

@Learath2 Learath2 commented Apr 8, 2017

Figured it out, just need to patch it, maybe tomorrow.

@def- def- closed this in 45bc79b Apr 9, 2017
black-roland added a commit to black-roland/goreddnet that referenced this issue Jun 4, 2017
black-roland added a commit to black-roland/goreddnet that referenced this issue Jun 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.