Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DON'T SUBMIT: Disable security #1608

Closed
wants to merge 1 commit into from

Conversation

@def-
Copy link
Member

commented Apr 9, 2019

-fstack-protector-all and FORTIFY_SOURCE
Just an attempt to see what performance impact it has

-fstack-protector-all and FORTIFY_SOURCE
Just an attempt to see what performance impact it has
@def-

This comment has been minimized.

Copy link
Member Author

commented Apr 9, 2019

Please try the nightly build of this change if you have performance problems with newer DDNet versions: https://ddnet.tw/news/nightly-builds/
Note that this has reduced security though. From my tests I don't see any performance change, but who knows, maybe this improves the common issues for some people?

@heinrich5991

This comment has been minimized.

Copy link
Contributor

commented Apr 9, 2019

We should probably swap -fstack-protector-all for -fstack-protector-strong.

@heinrich5991

This comment has been minimized.

Copy link
Contributor

commented Apr 9, 2019

(Note that -fstack-protector-all was also enabled in bam and that _FORTIFY_SOURCE should have a negligible performance impact.)

@def-

This comment has been minimized.

Copy link
Member Author

commented Apr 9, 2019

Well, it was just a hunch while I was enabling warnings closeby.

@def- def- closed this Apr 9, 2019
@def- def- deleted the def-:pr-disable-security branch Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.