Added eye wheel. Render only on ddrace/race/ictf+/dm+/gctf+ server.

[Chairn]

Eye wheel, use current tee skin for rendering. Works only on ddrace/race servers, and servers with a '+' in their gametype.

[heinrich5991]

Perhaps we should use a strategy for finding out whether the server supports this other than using its user agent string ("game type"). :)

[Chairn]

We can try /emote when joining server and see the server's answer.

For now, ive just tried several server, which is indeed, not the best.

[heinrich5991]

So. I guess this would be fine to merge now, but we should try to enhance the feature detection once #326 is merged. Will test the pull request.

[heinrich5991]

Mh. My impressions after testing it:

1. Why can you select the normal face expression of a tee? It doesn't seem to do anything.
2. I'm not sure the eye wheel is all to useful – after all you can modify the eyes using the normal speech-bubble emoticons as well, which is a lot more noticable.

[Chairn]

1. It should reset emote if there is already one in progress.
2. I agree, that's why i added cl_eye_wheel. But you can also just want to show that your happy or angry without the emoticon which last only few secs.
3. Maybe i should add cl_eye_duration to set the duration of the emote?

[heinrich5991]

I personally don't think this is useful enough to be a feature. I'm not the one who can reject ideas, so I guess you'll have to wait for feedback from someone else.

[nzyuzin]

The feature seems cool to me, I would love to be able to change facial expression of my tee without evoking emotions. :^)

Though I haven't seen the implementation, maybe you could attach a screenshot to PR so it would be easy for others to see how you implemented eye selection from user perspective?

[heinrich5991]

@nzyuzin

[nzyuzin]

Woah, that's absolutely fantastic!
Great job! 👍

[MyNewBie]

HClient already have it !

[H-M-H]

In my opinion this is only useful if this eyeemotes are permanent (last for a long time) because as heinrich5991 already pointed out normal emotes are sufficient in case you just want to change your eyes for a short time. Thus I suggest to set a high value as default.

[H-M-H]

@Chairn
So I just tested this locally and found some bugs:

1. on non ddrace or +... servers the selector is hidden but the chat message can be generated anyway
2. if you release between emote normal and blink some random text is spammed

Something else I would like to be improved:
int m_SelectedEmote;
int m_SelectedEmoticon;

// this is just confusing, no-one will get the difference at first glance thus something like m_SelectedEyeEmote would be way better (same for functions btw)

[heinrich5991]

Do we actually want this? I mean the idea is nice and all, but does it actually have proper usability? Or is it just a feature that everyone thinks looks nice but wouldn't actually use themselves.

[H-M-H]

Well I put it into my personal client some time ago and used it regulary, though with a long duration.
Edit: For some more opinions see responses to http://forum.ddnet.tw/viewtopic.php?f=5&t=559#p4867

[H-M-H]

see #373