Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added sv_dragger_range. #323

Merged
merged 2 commits into from Sep 7, 2015
Merged

Added sv_dragger_range. #323

merged 2 commits into from Sep 7, 2015

Conversation

@Chairn
Copy link
Contributor

@Chairn Chairn commented Sep 1, 2015

Maybe needs some more tests.

@@ -118,7 +117,7 @@ void CDragger::Drag()
else
Res = GameServer()->Collision()->IntersectNoLaserNW(m_Pos,
Target->m_Pos, 0, 0);
if (Res || length(m_Pos - Target->m_Pos) > 700)

This comment has been minimized.

@heinrich5991

heinrich5991 Sep 1, 2015
Member

Haha, very consistent use of constants before. :)

This comment has been minimized.

@Chairn

Chairn Sep 1, 2015
Author Contributor

Don't even know why he used 700 instead of LENGTH that was defined but used only once ^^.

@Ekidoxx
Copy link
Member

@Ekidoxx Ekidoxx commented Sep 2, 2015

What about adding also sv_turret_range or even better - making it as tunes?

@heinrich5991
Copy link
Member

@heinrich5991 heinrich5991 commented Sep 2, 2015

If those were made tunes, how would they interact with the tune zone feature?

@Ekidoxx
Copy link
Member

@Ekidoxx Ekidoxx commented Sep 2, 2015

change range of turrets / laser draggers placed inside of specified tune - if even possible ofc

@Chairn
Copy link
Contributor Author

@Chairn Chairn commented Sep 2, 2015

sv_plasma_range is for turrets.

heinrich5991 added a commit that referenced this pull request Sep 7, 2015
Added sv_dragger_range to control the length of the laser draggers.
@heinrich5991 heinrich5991 merged commit 48ecf3d into ddnet:master Sep 7, 2015
1 check passed
1 check passed
ci/circleci Your tests passed on CircleCI!
Details
@heinrich5991
Copy link
Member

@heinrich5991 heinrich5991 commented Sep 7, 2015

Looks good to me. Sorry for the long merging delay.

@Chairn Chairn deleted the Chairn:drag_range branch Jul 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants