Don't reset cl_antiping subconfig on restart
#333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/engine/client/client.cpp
Outdated
| { | ||
| g_Config.m_ClAntiPingPlayers = 1; | ||
| g_Config.m_ClAntiPingGrenade = 1; | ||
| g_Config.m_ClAntiPingWeapons = 1; |
Member
Author
There was a problem hiding this comment.
Should probably only set this to 1 if m_ClAntiPing is 0.
Contributor
There was a problem hiding this comment.
Why not keeping the previously set config variables here?
Member
Author
There was a problem hiding this comment.
Because the old behavior reset all these to 0 when the player set m_ClAntiPing to 0. With the new system, they don't get set to 1 automatically when the m_ClAntiPing setting is set to 1, thus all antiping measures would be disabled by default if someone used an old config without this workaround.
If cl_antiping is 1, the previous version of the code would have set all other antiping variables to 1 anyway, so with this commit the user can retain their antiping config if they configured after the last start of the old client.
This would also happen anyway as no config is treated as config version 0, since cl_antiping is 0, all the subconfigs would be set to 0.
Member
|
everything worked while testing and code looks fine too, gonna merge |
H-M-H
added a commit
that referenced
this pull request
Oct 21, 2015
Don't reset `cl_antiping` subconfig on restart
SollyBunny
pushed a commit
to SollyBunny/ddnet
that referenced
this pull request
Apr 9, 2025
…layer will be frozen for (ddnet#333)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With backward-compatiblity (sets
cl_antiping_*to 1 on first start.)Fixes #327.