cl_text_entities (show/hide text in entities) for performance

[rbmz]

Signed-off-by: rbmz rbmz@users.noreply.github.com

[heinrich5991]

See https://github.com/ddnet/ddnet/pull/340/files?w=1 for an easier-to-read diff.

[heinrich5991]

This and below should probably !g_Config.m_ClTextEntities. Otherwise, the code looks fine to me. What's your use case for this? Does the text rendering slow down the client?

[cinaera]

Looks fine as a temporal workaround.
Changes to the text render would improve the performance overall (batching the draw calls)

[Chairn]

gfx_text_overlay does the same no?

[rbmz]

@heinrich5991: yes

@Chairn:
I did not know about gfx_text_overlay.
Seems to be used as a parameter to decide whether to hide text when zooming out:

  if(EndX - StartX > g_Config.m_GfxScreenWidth / g_Config.m_GfxTextOverlay || EndY - StartY > g_Config.m_GfxScreenHeight / g_Config.m_GfxTextOverlay)
    return; // its useless to render text at this distance

it does hide text in teleporters, it also completely hides speedups (instead of just the speedup numbers)

[H-M-H]

I tested this locally and everything looks fine so far
@rbmz please be so kind and change g_Config.m_ClTextEntities == 0 to !g_Config.m_ClTextEntities as heinrich5991 suggested, then I will likely merge :)

[timakro]

Since HMH and heinrich looked at it I just merged it and
changed g_Config.m_ClTextEntities == 0 to !g_Config.m_ClTextEntities in 201782d.

[heinrich5991]

Thanks for your contribution!