New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset statboard after a game restart #366

Merged
merged 2 commits into from Nov 15, 2015

Conversation

Projects
None yet
3 participants
@nzyuzin
Contributor

nzyuzin commented Nov 12, 2015

Fixes #335

The details of this PR are written in #335. The way I chose to solve the issue decouples statboard reset from the demo recording as it was suggested in the issue.

s_GameOver = m_Snap.m_pGameInfoObj->m_GameStateFlags&GAMESTATEFLAG_GAMEOVER;
// Reset statboard when new round is started (RoundStartTick changed)
// New round is usually started after `restart` on server
if ((m_Snap.m_pGameInfoObj->m_RoundStartTick - m_LastRoundStartTick > 2)

This comment has been minimized.

@heinrich5991

heinrich5991 Nov 13, 2015

Contributor

Why > 2?

@nzyuzin nzyuzin force-pushed the nzyuzin:master branch to e63e9ee Nov 13, 2015

@H-M-H

This comment has been minimized.

Member

H-M-H commented Nov 15, 2015

Looks fine to me.

H-M-H added a commit that referenced this pull request Nov 15, 2015

Merge pull request #366 from nzyuzin/master
Reset statboard after a game restart

@H-M-H H-M-H merged commit 2fbccb8 into ddnet:master Nov 15, 2015

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment