Fix wrong calculation of weapon Angle in demo player #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Where does these values ( |
|
Yes. Sorry, I had to use pi, my bad. |
|
Well I tested it and it seems to work, maybe you could shortly explain what was wrong. |
|
Looks fine now. |
H-M-H
added a commit
that referenced
this pull request
Nov 15, 2015
Fix wrong calculation of weapon Angle in demo player
| { | ||
| Player.m_Angle += 256.0f * 2 * pi; | ||
| Angle = mix((float)Prev.m_Angle, (float)Player.m_Angle, IntraTick) / 256.0f; | ||
| } |
There was a problem hiding this comment.
Not sure why you're doing it down here instead of near line 409.
There was a problem hiding this comment.
Well like this it is just executed less often (this correction is not required if you are the local character). In all other cases it is applied.
There was a problem hiding this comment.
By that logic, you should have moved the assignemnt part of line 409 down here as well.
heinrich5991
added a commit
to heinrich5991/ddnet
that referenced
this pull request
Nov 15, 2015
H-M-H
added a commit
that referenced
this pull request
Nov 15, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix wrong calculation of weapon Angle in demo player, more here: http://forum.ddnet.tw/viewtopic.php?f=45&t=2717
and
Add *.dll to .gitignore (for Windows)