New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong calculation of weapon Angle in demo player #369
Conversation
Where does these values ( |
Yes. Sorry, I had to use pi, my bad. |
Well I tested it and it seems to work, maybe you could shortly explain what was wrong. |
Looks fine now. |
Fix wrong calculation of weapon Angle in demo player
{ | ||
Player.m_Angle += 256.0f * 2 * pi; | ||
Angle = mix((float)Prev.m_Angle, (float)Player.m_Angle, IntraTick) / 256.0f; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why you're doing it down here instead of near line 409.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well like this it is just executed less often (this correction is not required if you are the local character). In all other cases it is applied.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By that logic, you should have moved the assignemnt part of line 409 down here as well.
Fix wrong calculation of weapon Angle in demo player, more here: http://forum.ddnet.tw/viewtopic.php?f=45&t=2717
and
Add *.dll to .gitignore (for Windows)