added (console-)command usage #389
Conversation
Now you have duplicate information, |
This kinda duplicates work of #388. |
Also, #388 obviously won't work. |
I guess the best option would be to rework all the "Help" argument inside the Console()->Register. |
Another idea : modify the parser to have a comment char like |
the commandparamsstring: "s[file]"
@def- @Laxa I liked you idea the new format is now: parametertype + description in brackets. Edit: the only problem left is that old clients do not have enough space in their buffer to display the whole parameterstring in remote-console but I guess this problem is neglectable. |
beyond the given string
Okay, no complaints so far, my locals tests were fine so I will merge this. |
added (console-)command usage fixes #387
If you're asking for complaints, this is what I thought when reading the code:
|
As you see I did it with a usage string first but as deen pointed out this is kinda redundant and adding this requires changes in networkcode. The problem is now that the server can send further information here: ddnet/src/engine/server/server.cpp Lines 896 to 900 in e41b4f4 ddnet/src/engine/client/client.cpp Lines 1614 to 1621 in e41b4f4 edit: thanks for complaints btw :D |
would fix #387
However, I am not exactly satisfied with this as servers can not send the usage to clients properly. At the moment servers just concat params and usage and sent it to client, which causes that old clients can not display the whole text as their buffer is too small.