added (console-)command usage

[H-M-H]

would fix #387
However, I am not exactly satisfied with this as servers can not send the usage to clients properly. At the moment servers just concat params and usage and sent it to client, which causes that old clients can not display the whole text as their buffer is too small.

[def-]

Now you have duplicate information, ?s and [file]. Alternatively the parser could be changed to parse [file] but that might be too much work.

[heinrich5991]

This kinda duplicates work of #388.

[H-M-H]

Well it was already done when #388 appeared.

@def- like this we would loose typeinformation.

[Henningstone]

Also, #388 obviously won't work.

[laxa]

I guess the best option would be to rework all the "Help" argument inside the Console()->Register.
Sadly, we can't always have a solution that will fit all cases. Client needs to be updated once in a while.

[laxa]

Another idea : modify the parser to have a comment char like ?s#[File]

[H-M-H]

@def- @laxa I liked you idea the new format is now: parametertype + description in brackets.
Example: "i[some number] s[a string] ?i[optional number]"

Edit: the only problem left is that old clients do not have enough space in their buffer to display the whole parameterstring in remote-console but I guess this problem is neglectable.

[H-M-H]

Okay, no complaints so far, my locals tests were fine so I will merge this.

[heinrich5991]

If you're asking for complaints, this is what I thought when reading the code:

1. Why stuff the extra information into the format string for the parameters instead of making a second parameter that contains a space (or whatever)-separated list of parameter names?
2. This is as you said not really backward-compatible, but it wouldn't be hard with 1).

[H-M-H]

As you see I did it with a usage string first but as deen pointed out this is kinda redundant and adding this requires changes in networkcode. The problem is now that the server can send further information here:

ddnet/src/engine/server/server.cpp

Lines 896 to 900 in e41b4f4

	CMsgPacker Msg(NETMSG_RCON_CMD_ADD);
	Msg.AddString(pCommandInfo->m_pName, IConsole::TEMPCMD_NAME_LENGTH);
	Msg.AddString(pCommandInfo->m_pHelp, IConsole::TEMPCMD_HELP_LENGTH);
	Msg.AddString(pCommandInfo->m_pParams, IConsole::TEMPCMD_PARAMS_LENGTH);
	SendMsgEx(&Msg, MSGFLAG_VITAL, ClientID, true);

but the new clients would not be able to process it as they do not know if the server already sends them:

ddnet/src/engine/client/client.cpp

Lines 1614 to 1621 in e41b4f4

	else if((pPacket->m_Flags&NET_CHUNKFLAG_VITAL) != 0 && Msg == NETMSG_RCON_CMD_ADD)
	{
	const char *pName = Unpacker.GetString(CUnpacker::SANITIZE_CC);
	const char *pHelp = Unpacker.GetString(CUnpacker::SANITIZE_CC);
	const char *pParams = Unpacker.GetString(CUnpacker::SANITIZE_CC);
	if(Unpacker.Error() == 0)
	m_pConsole->RegisterTemp(pName, pParams, CFGFLAG_SERVER, pHelp);
	}

edit: thanks for complaints btw :D