Update pagy.rb to handle asking for a page > the last page #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raising an error when what was a good page number is no longer good if a waste of code! Exceptions should only be raised for exceptional conditions no standard processing. when i first view the page there are 20 tasks... someone else bulk closes 15... now there is only 1 page and a refresh needs to by exception handed.... NO WAY!
weiserma
changed the title
|
With your change we would impose a behavior that is not compatible with certain API clients (that stop fetching pages only when they get an empty page). And what if a user would actually want to return page 1 or do anything else instead of getting the last page? The Overflow extra handles a few common cases (including so... "NO WAY!" 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
raising an error when what was a good page number is no longer good if a waste of code! Exceptions should only be raised for exceptional conditions no standard processing.
when i first view the page there are 20 tasks... someone else bulk closes 15... now there is only 1 page and a refresh needs to by exception handed.... NO WAY!