Avoid crash by verifying the existence of SIGHUP before accessing it. #219

Merged
merged 1 commit into from Jul 9, 2012

Conversation

Projects
None yet
3 participants
Contributor

MarkDBlackwell commented Jul 8, 2012

See also my comment in issue 216.

Issue 216 occurred due to pull request 201 being accepted without sufficient test support.

Not that I'm supplying a test either ;-/

Testing this might depend on the way Ruby was installed on Windows. On bare Windows, SIGHUP does not exist. But in cygwin, and (I think) mingw e.g. Git-bash, SIGHUP does exist. So, all the available ways to run Ruby on Windows should be tested—I suspect some were not!

Obviously, BTW, it's best directly to detect the presence of the feature in the local Ruby interpreter (the existence of SIGHUP) rather than detect the O/S version.

This pull request passes (merged ae7aeab into 9901b9f).

Contributor

MarkDBlackwell commented Jul 8, 2012

The test build appears (to me) to exclude MS Windows, BTW.

@ddollar ddollar added a commit that referenced this pull request Jul 9, 2012

@ddollar ddollar Merge pull request #219 from MarkDBlackwell/patch-1
Avoid crash by verifying the existence of SIGHUP before accessing it.
3e71fea

@ddollar ddollar merged commit 3e71fea into ddollar:master Jul 9, 2012

Owner

ddollar commented Jul 9, 2012

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment