Upstart pidfile generation #255

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@masterkorp

Hack that generates a pifile to to /var/run providing a standard way for others tools like monit to check processs status.

  • It fits right in with the current exec
  • Command and grep is an essential package comming preinstalled in all ubuntu machines, so its safe to use it.
  • Does not require any more variable setting.
@travisbot

This pull request fails (merged b3448b4 into e06d36b).

@masterkorp

Another more elegant solution would be using the start-stop-daemon script in the exec line. It may have some changes. I can test if you want

@ddollar
Owner
ddollar commented Aug 27, 2012

I'd be interested in seeing a pull request that uses start-stop-daemon

@masterkorp

will do

@masterkorp

So after trying a lot, i got to these 2 points that make using start-stop-deamon a problem:

  1. Start-stop-daemon can only be run as root (it can start the process itself as any user tough), that means that the upstart script needs to be started as root, that might be an impedance for some use cases.

  2. I failed to export ENV vars sucefully with it

Either way I think that should be possible to change location, would you be intrested if i add flag to set the pidfile path ? Since it will cause permission problems for some uses cases (as the travis builder says)

@ddollar
Owner
ddollar commented Sep 14, 2012

I would prefer not to add export flags that are specific to a given exporter.

Perhaps you could have this be configurable via environment variable?

@ddollar ddollar closed this Apr 14, 2013
@ddollar
Owner
ddollar commented Apr 14, 2013

Thanks for the pull request, but I'm going to close it in favor of simplicity. I'm trying not to add exporter-specific arguments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment