JRuby 1.9 doesn't require posix/spawn #291

Merged
merged 1 commit into from Jan 14, 2013

Conversation

Projects
None yet
7 participants
Contributor

liveh2o commented Nov 28, 2012

Since JRuby 1.9 doesn't require posix/spawn, only follow that path if JRuby is loaded and running in 1.8 mode.

This is very close to the solution proposed by @danielfarrell in #290, but follows the original spirit a little more closely.

I can also confirm that both solutions work for me, running foreman in JRuby 1.7 on Java 7.

Contributor

danielfarrell commented Nov 28, 2012

+1 this is how to do it, I'll close mine

+1 works for me

glebm commented Dec 15, 2012

+1

This worked for me too, albeit with a few warnings:

$ foreman start
file:/Users/seacreature/.rvm/rubies/jruby-1.7.1/lib/jruby.jar!/jruby/kernel19/process.rb:4 warning: unsupported spawn option: err
file:/Users/seacreature/.rvm/rubies/jruby-1.7.1/lib/jruby.jar!/jruby/kernel19/process.rb:4 warning: unsupported spawn option: out
file:/Users/seacreature/.rvm/rubies/jruby-1.7.1/lib/jruby.jar!/jruby/kernel19/process.rb:4 warning: unsupported spawn option: err
file:/Users/seacreature/.rvm/rubies/jruby-1.7.1/lib/jruby.jar!/jruby/kernel19/process.rb:4 warning: unsupported spawn option: out

Any other reason why this patch has not been merged yet? Is there anything else that needs to be done to make it ready to pull?

@ddollar ddollar added a commit that referenced this pull request Jan 14, 2013

@ddollar ddollar Merge pull request #291 from liveh2o/master
JRuby 1.9 doesn't require posix/spawn
cd2c255

@ddollar ddollar merged commit cd2c255 into ddollar:master Jan 14, 2013

1 check failed

default The Travis build failed
Details

❤️

I'm still seeing this in foreman 0.63. What am I missing?

foreman --version
0.63.0
foreman start
file:/Users/jared/.rbenv/versions/jruby-1.7.9/lib/jruby.jar!/jruby/kernel19/process.rb:14 warning: unsupported spawn option: err
file:/Users/jared/.rbenv/versions/jruby-1.7.9/lib/jruby.jar!/jruby/kernel19/process.rb:14 warning: unsupported spawn option: out
file:/Users/jared/.rbenv/versions/jruby-1.7.9/lib/jruby.jar!/jruby/kernel19/process.rb:14 warning: unsupported spawn option: err
file:/Users/jared/.rbenv/versions/jruby-1.7.9/lib/jruby.jar!/jruby/kernel19/process.rb:14 warning: unsupported spawn option: out
Contributor

danielfarrell commented Dec 20, 2013

Those are only warnings. JRuby says they will support those options in the future, at which point those will go away.

OK, thanks. It's interesting that jruby chooses to print warnings to stderr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment