Allow buildpack to export environment for subsequent packs #11

Closed
wants to merge 4 commits into
from

7 participants

@davidjrice

This enables a buildpack to become entirely composable. Great work by @salsify

For example. Am currently using this to enable deploying a node.js app that depends on cairo.

Note, as some of the existing heroku buildpacks completely override previously set ENV variables at compile time, tweaks may be needed in other buildpacks themselves.

heroku/heroku-buildpack-nodejs#30

@marcolinux

+1
any chance to integrate this pull request?
(Or equivalently) any workaround to pass enviroment variable between buildpacks?
(Unfortunately) any library which is requiring the usage of pkg-config which need to be available at compilation time will require hack on the main buildpack.
It is specifically an issue for nodejs binded libraries
thanks

@nathanaeljones

I'm running into this trying to use the npm package nodelua. The lua buildpack runs first, but has no way to pass on environment variables to the next buildpack.

@kennethreitz

I wonder if we could utilize the new .profile.d scripts to enable this functionality.

@mojodna

Alas, not as currently implemented, since the paths will be different at build- and runtime.

@manterfield manterfield added a commit to manterfield/heroku-buildpack-multi that referenced this pull request Jun 21, 2014
@manterfield manterfield Adding env export for next buildpack
This is taken from ddollar#11

I am testing to see if this fixes the collectstatic issue experienced when deploying to heroku (possibly PYTHONPATH not currently set for python buildpack)
f57b537
@ddollar
Owner

Sorry for the delay. If you rebase this I'd be happy to merge.

@ddollar ddollar added the enhancement label Nov 7, 2014
@mojodna

All things being equal between this and #18, I have multiple buildpacks relying on #18's export behavior. (@davidjrice - do you have / know of buildpacks relying on this?)

(I'm slightly partial to the exports living outside bin, as they may be created dynamically; not that bin precludes this though.)

@ddollar
Owner

Merged #18

@ddollar ddollar closed this Nov 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment