Fix leaked return of CFUUIDCreate() (reported by clang static analyze…

…r). Also make GC dual-mode safe by calling NSMakeCollectable() on return of CFUUIDCreateString()
ddribin · May 25, 2009 · b1fb2b9 · b1fb2b9
1 parent 15227df
commit b1fb2b9
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/lib/NSURLRequest+postForm.m b/lib/NSURLRequest+postForm.m
@@ -48,7 +48,13 @@ + (id)requestWithURL:(NSURL*)url postForm:(NSDictionary*)values {
     // Create the mime multipart boundary.
 
     // TODO scan `values` to ensure uniqueness of `boundary`. Loop+regen UUID if collision is discovered.
-    NSString *uuid = [(id)CFUUIDCreateString(kCFAllocatorDefault, CFUUIDCreate(kCFAllocatorDefault)) autorelease];
+    CFUUIDRef cfUuid = CFUUIDCreate(kCFAllocatorDefault);
+    NSString * uuid = (id)CFUUIDCreateString(kCFAllocatorDefault, cfUuid);
+    CFRelease(cfUuid);
+#if MAC_OS_X_VERSION_MAX_ALLOWED >= MAC_OS_X_VERSION_10_5
+    uuid = NSMakeCollectable(uuid);
+#endif
+    uuid = [uuid autorelease];
     NSString *boundary = [NSString stringWithFormat:@"x-mime-boundary://%@", uuid];
 
     //--