Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add_difference() emmeans implementation #1112

Merged
merged 9 commits into from Jan 20, 2022
Merged

add_difference() emmeans implementation #1112

merged 9 commits into from Jan 20, 2022

Conversation

ddsjoberg
Copy link
Owner

@ddsjoberg ddsjoberg commented Jan 19, 2022

What changes are proposed in this pull request?

  • New method added for add_difference() and add_p() using emmeans::emmeans() to estimate marginal means/least-squares means. The method can handle continuous variables, binary variables, and random intercept models.

Reviewer Checklist (if item does not apply, mark is as complete)

  • Ensure all package dependencies are installed by running renv::install()
  • PR branch has pulled the most recent updates from master branch. Ensure the pull request branch and your local version match and both have the latest updates from the master branch.
  • If an update was made to tbl_summary(), was the same change implemented for tbl_svysummary()?
  • If a new function was added, function included in _pkgdown.yml
  • If a bug was fixed, a unit test was added for the bug check
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features. Review coverage with covr::report(). Before you run, set Sys.setenv(NOT_CRAN="true") and begin in a fresh R session without any packages loaded.
  • R CMD Check runs without errors, warnings, and notes
  • usethis::use_spell_check() runs with no spelling errors in documentation

When the branch is ready to be merged into master:

  • Update NEWS.md with the changes from this pull request under the heading "# gtsummary (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • Increment the version number using usethis::use_version(which = "dev")
  • Run codemetar::write_codemeta()
  • Run usethis::use_spell_check() again
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge".

@ddsjoberg ddsjoberg changed the title first draft of add_p() emmeans implementation add_difference() emmeans implementation Jan 19, 2022
@ddsjoberg ddsjoberg marked this pull request as ready for review January 19, 2022 18:25
@ddsjoberg ddsjoberg merged commit 2ccdba7 into main Jan 20, 2022
@ddsjoberg ddsjoberg deleted the emmeans branch January 20, 2022 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants