Permalink
Browse files

fix try catch bug in get & update test

  • Loading branch information...
1 parent 0c6155d commit 3bb605c19afefc891319650a7d08c2afa77c6b08 @dead-horse committed Oct 17, 2012
Showing with 16 additions and 9 deletions.
  1. +8 −6 lib/connect-redis.js
  2. +8 −3 test.js
View
@@ -91,14 +91,16 @@ module.exports = function(connect){
debug('GET "%s"', sid);
this.client.get(sid, function(err, data){
if (err) return fn(err);
+ if (!data) return fn();
+ var result;
+ data = data.toString();
+ debug('GOT %s', data);
try {
- if (!data) return fn();
- data = data.toString();
- debug('GOT %s', data);
- fn(null, JSON.parse(data));
+ result = JSON.parse(data);
} catch (err) {
- fn(err);
- }
+ return fn(err);
+ }
+ return fn(null, result);
});
};
View
@@ -15,12 +15,12 @@ store.client.on('connect', function(){
store.set('123', { cookie: { maxAge: 2000 }, name: 'tj' }, function(err, ok){
assert.ok(!err, '#set() got an error');
assert.ok(ok, '#set() is not ok');
-
+
// #get()
store.get('123', function(err, data){
assert.ok(!err, '#get() got an error');
assert.deepEqual({ cookie: { maxAge: 2000 }, name: 'tj' }, data);
-
+
// #set null
store.set('123', { cookie: { maxAge: 2000 }, name: 'tj' }, function(){
store.destroy('123', function(){
@@ -29,6 +29,11 @@ store.client.on('connect', function(){
store_alt.client.end();
});
});
- })
+ throw new Error('Error in fn');
+ });
});
});
+
+process.once('uncaughtException', function (err) {
+ assert.ok(err.message === 'Error in fn', '#get() catch wrong error');
+});

0 comments on commit 3bb605c

Please sign in to comment.