Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: resolve plugins directly from the app container #4

Merged
merged 1 commit into from Mar 12, 2019

Conversation

Projects
None yet
2 participants
@faustbrian
Copy link
Contributor

faustbrian commented Mar 12, 2019

The module.exports = new App() at the bottom of the app.js files means that the app object will exist before the container has anything registered.

Exporting instances that rely on the container before the container exists should be avoided.

@roks0n

This comment has been minimized.

Copy link
Contributor

roks0n commented Mar 12, 2019

I agree, thanks for the PR - really appreciate it!

@roks0n roks0n merged commit 71f621f into deadlock-delegate:master Mar 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.