Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error can't be translated, because of product name in message #41

Closed
pstuifzand opened this issue Jun 7, 2021 · 1 comment
Closed

Comments

@pstuifzand
Copy link
Contributor

On this line

$errors[] = __("We can\'t add ({$product->getName()}) item to your shopping cart right now.");

the error can't be translated, because of the product name in de message. You would need a translation for every product name.

This is the patch we use to fix this.

$errors[] = __("We can\'t add %1 to your shopping cart right now.", $product->getName());
@doldersma
Copy link
Contributor

Hi, thank you for pointing this out, we will apply this patch in version 1.0.27.
Also in the same file on line 188.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants