Testing the utils #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AUTHORS.rst
Outdated
Contributor
Author
There was a problem hiding this comment.
I wanted to ask if I can do this for all? It just renders nicer.
I don't mind switching it back or changing all. you just got to it before I could ask in a comment 😉
Contributor
There was a problem hiding this comment.
I like that both name and link are explicitly rendered which is used for PDF docs, etc... I dont have any strong preference either way
Contributor
Author
There was a problem hiding this comment.
Thats fine. Let it build, I'll push to follow existing.
Two utils methods were lacking coverage: * get_attr_from_base_classes * get_class_name_with_new_suffix Added a .coveragerc so that coverage would not be tracking coverage of actual tests code. Docstrings were added for future reference.
drf_braces/utils.py
Outdated
Contributor
There was a problem hiding this comment.
example might be nice:
Example:
::
get_class_name_with_new_suffix(FooForm, 'Form', 'NewForm') == 'FooNewForm'
As part of a review: * get_attr_from_base_classes used kwargs to get the `default`. Now `default` is an explicit kwarg, updated docstring and code to reflect this * updated docstring for `get_class_name_with_new_suffix` with an example
Contributor
Author
There was a problem hiding this comment.
If this is acceptable, I think we can merge.
The rest of the comments were about docstrings
Contributor
There was a problem hiding this comment.
fine. still not a fan but ok.
Contributor
Author
|
Wooohoooo!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From commit messages: