Use and document VectorTools::ExcPointNotAvailableHere #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
| DeclException0 (ExcPointNotAvailableHere); | ||
| typedef VectorTools::ExcPointNotAvailableHere ExcPointNotAvailableHere DEAL_II_DEPRECATED; |
There was a problem hiding this comment.
Ah, clever solution to being backward compatible :-)
|
Don't you want to change the place where the exception is throw as well, to avoid using the (now deprecated) local typedef? |
|
Also references #610 |
ExcPointNotAvailableHere is duplicated in VectorTools and FEFieldFunction and is awkward to use in the latter because of the template arguments. - provide textual description of Exception - deprecate the version in FEFieldFunction - update documentation - update test
|
fixed indentation and addressed your valid point! |
bangerth
added a commit
that referenced
this pull request
Mar 4, 2015
Use and document VectorTools::ExcPointNotAvailableHere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExcPointNotAvailableHere is duplicated in VectorTools and
FEFieldFunction and is awkward to use in the latter because of the
template arguments.