Restrict instantiations in GridRefinement to Vector #5861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masterleinad
force-pushed
the
fix_unused_fraction
branch
from
360d5c8
to
dfb0498
Compare
masterleinad
force-pushed
the
fix_unused_fraction
branch
from
dfb0498
to
41826cf
Compare
|
/run-tests |
|
I looked through my collection of user codes and it looks like everyone already does this. |
|
I think that @masterleinad @davydden @bangerth and myself are all OK with this change; I'll merge it in a day or so unless I hear an objection. |
drwells
approved these changes
Feb 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5858. As
Vector<Number>are the only types that are used (and needed) in theGridRefinementfunctions, restrict the signatures to these.