Warning for custom converter needs to be updated #15

Closed
baank opened this Issue Nov 3, 2012 · 2 comments

Comments

Projects
None yet
2 participants
Contributor

baank commented Nov 3, 2012

When dealing with objects that have no built in converter the following is shown:

Caused by: java.lang.IllegalArgumentException: .... You need to either add one of the @*ToOne annotations, @Embedded, @transient or add your own converter calling EntityMgrFactory.setup(Map<Class, Converter>) which will then work for all fields of that type OR add @column(customConverter=YourConverter.class) or finally if we missed a standard converter, we need to add it in file InspectorField.java in the constructor and it is trivial code(and we can copy the existing pattern)

This should be updated to mention the new @nosqlconverter annotation.

And this part (EntityMgrFactory.setup) should be removed as you can't do this from the Play plugin.

Contributor

baank commented Nov 23, 2012

For some reason everything is in the one pull request. This has been fixed in commit:

https://github.com/taligent/playorm/commit/23c32f63a0f9e4853b3b53700e34530a990bc5ca

Collaborator

easility commented Nov 27, 2012

Ok. Great. Code has been merged.
Thanks for fixing it. Closing this issue.

easility closed this Nov 27, 2012

@easility easility added a commit that referenced this issue Mar 4, 2013

@easility easility Merge pull request #15 from deanhiller/master
merging deanhiller with easility
6640d14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment