Skip to content
Commits on May 8, 2012
  1. @wkeese

    revert [28485] as it actually makes things more difficult for the new…

    … doc parser (especially since it's accessing an undefined variable named "declare") , refs #15292 !strict
    wkeese committed May 8, 2012
  2. @wkeese

    Use overflow:visible rather than overflow:hidden so that border displ…

    …ays on drop down menus in tundra. Fixes #15215 !strict.
    wkeese committed May 8, 2012
  3. @wkeese

    Hide the !MenuItem focus outline since focus is already clear from th…

    …e shading of the selected !MenuItems, or in high contrast mode, from a solid border drawn around selected !MenuItem labels.
    This also works around the webkit bug displaying focus on table rows.
    Fixes #15241.
    wkeese committed May 8, 2012
  4. @wkeese

    The change in [22969] causes a slight problem on IE9 where tooltip te…

    …xt is unnecessarily split across two lines. So, add a few pixels.
    Also fixing unnecessary manual adjustment for connector width.   It's included in the the width of Tooltip.domNode.
    Seems like all the browser sniff tests in this file could be changed to "feature tests", but I will leave that for a different checkin.
    Fixes #15299 !strict.
    wkeese committed May 8, 2012
  5. @wkeese
Commits on May 5, 2012
  1. @wkeese

    Prefer setObject() to getObject() since it avoids needing a doc parse…

    …r hint, and since it isolates the code to set global variables (which we will remove for 2.0).
    I wish we didn't have code setting global variables at all, especially since dojo.require() automatically creates a global for the module, but I suppose some user code might be using AMD syntax to require modules yet still expecting globals to be created.
    Refs #14980 !strict.
    wkeese committed May 5, 2012
  2. @wkeese

    Fix API doc for dijit kwargs parameters. There's a lot of inheritance…

    … going on, which requires many modules to logically export their kwarg definitions. Refs #14980 !strict.
    wkeese committed May 5, 2012
Commits on May 4, 2012
  1. Fixes #15207. Mask invalid error after a backspace that corrects the …

    …input for autoComplete=true FilteringSelect. Added automated test.
    Douglas Hays committed May 4, 2012
  2. @wkeese
  3. @wkeese

    Fix missed conversions of selectionapi calls to this._sCall() in [284…

    …13], causing !EnterKeyHandling test to fail on chrome, refs #15216 !strict.
    wkeese committed May 4, 2012
Commits on May 3, 2012
  1. Fixes #15270. Change _isDefinitelyOutOfRange to not return true for u…

    …ndefined/null values, and added an automated testcase.
    Douglas Hays committed May 3, 2012
Commits on May 2, 2012
  1. @wkeese

    Remove doc comment hints about require()'d modules. They actually con…

    …fuse the new doc parser rather than helping it. Refs #14980 !strict.
    wkeese committed May 2, 2012
  2. @wkeese
  3. @wkeese
Commits on May 1, 2012
  1. @kfranqueiro
  2. Add doc comments to dijit/registry.js so it appears in api.xml. Fixes…

    … #15292.
    Mark Hays committed May 1, 2012
  3. @wkeese
Commits on Apr 30, 2012
  1. @wkeese

    Localize alt and title attribute on <img> node, to prevent tooltip on…

    … IE7 being English.
    Removed the BIDI tests for !ColorPalette direction since it turns out there's no requirement about which direction the colors display in RTL mode.
    Fixes #15284 !strict.
    wkeese committed Apr 30, 2012
  2. @wkeese

    Fix a few calls to this._sCall(), the last parameter needs to be an a…

    …rray, refs #15216 !strict.
    wkeese committed Apr 30, 2012
  3. @wkeese

    Modified version of Kitson's patch to support auto require in the par…

    Parser runs the same as before, unless scan() sees undefined modules, in which case it loads the modules asynchronously, and then runs patch-up code on list[], to fill in the missing constructors and remove any nodes that shouldn't be instantiated to due to a stopParser:true setting on an ancestor.
    One API change is that scan() now returns a Promise.  That's OK since scan() is new for 1.8.
    Fixes #14591 !strict.
    wkeese committed Apr 30, 2012
Commits on Apr 29, 2012
  1. @wkeese

    Modified version of Kitson's patch to support declarative require in …

    …the parser:
    1. Before looking for data-dojo-type nodes, the parser scans for <script type="dojo/require"> nodes, loads the specified modules, and then (asynchronously) continues the parse.   If no <script type="dojo/require"> tags are present, parsing is synchronous like before.
    2. <script type="dojo/require"> syntax: hash mapping variable name to module id, ex: <script type="dojo/require"> baz: "acme/baz", zing: "acme/zing" </script>
    3. Parser return value: The parser's return value can be used as a Promise.   In addition, for backwards compatibility, for markup without <script type=dojo/require> tags, the return value can be used as an array of widgets.  (This code is common to #14591.)
    4. Corresponding changes to html.!ContentSetter and dijit/layout/!ContentPane to handle asynchronous parsing.   These changes were taken from #14591 and tests will be added later when that ticket is closed.
    Fixes #15118, refs #14591 !strict.
    wkeese committed Apr 29, 2012
Commits on Apr 27, 2012
  1. @wkeese

    When is used as a scope for global variables, rather than …

    …a reference to the browser's Window object, use instead. I'd prefer to use neither but that's an arguable break in backwards compatibility. At least this makes things clearer and in many cases removes the dependency on dojo/_base/window.
    Refs #15275 !strict.
    wkeese committed Apr 27, 2012
  2. @wkeese

    Fix race condition where drop down closes before focus timer fires, f…

    …ixes #15197 !strict.
    wkeese committed Apr 27, 2012
  3. @wkeese

    Fix error from [28401], which removed the dojo/_base/window dependenc…

    …y but left references to it, thanks Sudoh-san, refs #15216 !strict.
    wkeese committed Apr 27, 2012
  4. @wkeese
Commits on Apr 26, 2012
  1. @wkeese
  2. @wkeese

    Remove some unused dependencies plus supply missing document paramete…

    …r to dom.byId(), refs #15216 !strict.
    wkeese committed Apr 26, 2012
  3. @wkeese
Commits on Apr 25, 2012
  1. Fixes #15256. Check for disabled and readOnly before searching on key…

    … input. Added automated test. !strict
    Douglas Hays committed Apr 25, 2012
  2. @wkeese

    Move hccss to dojo/core (leaving back-compat stub in dijit) and make …

    …dojo/dnd dependency explicit. Fixes #15230 !strict.
    wkeese committed Apr 25, 2012
Commits on Apr 24, 2012
  1. @wkeese

    A few fixes around win.doc references:

    1. Standardize on this._sCall() interface to access selection API.   Also looked at passing window parameter to each selection method, or creating a Selection class that's attached to a window on creation... but just did the simple thing for now.   OTOH the range API takes a window parameter.
    2. remove unneeded win.withGlobal(), win.withDoc() calls
    3. misc cleanup
    Refs #15216 !strict.
    wkeese committed Apr 24, 2012
Commits on Apr 22, 2012
  1. @wkeese

    Add missing (optional) document parameter for various DOM methods, an…

    …d update code (mainly dijit code) to pass in the document to those methods, fixes #15229 !strict.
    wkeese committed Apr 22, 2012
  2. @wkeese
Something went wrong with that request. Please try again.