New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.xls/xlsx support #42

Closed
levivm opened this Issue Aug 10, 2014 · 4 comments

Comments

Projects
None yet
2 participants
@levivm
Contributor

levivm commented Aug 10, 2014

I think, it would be nice support .xls/xlsx files, I think I can do it using xlrd lib

@deanmalmgren

This comment has been minimized.

Owner

deanmalmgren commented Aug 10, 2014

Sounds great. Feel free to send in a separate PR or attach your code to this issue with http://issue2pr.herokuapp.com. thanks!

@levivm

This comment has been minimized.

Contributor

levivm commented Aug 10, 2014

Fine Im working on it, I am almost done. Just a question, How iwould it be better, print by columns or rows.

file
r r r r r
x x x x

print result
option 1:
r r r r r
x x x x

option 2:
r x
r x
r x
r x
r x

@levivm levivm closed this Aug 10, 2014

@levivm levivm reopened this Aug 10, 2014

@deanmalmgren

This comment has been minimized.

Owner

deanmalmgren commented Aug 10, 2014

I'm indifferent, really. The general rule of thumb for this package is to try and faithfully reproduce the sequence of words in any given file so that subsequent natural language processing and modeling works as expected. My gut is to go with the "printing by row" option:

r r r r r
x x x x x

But I could easily be convinced otherwise.

Thanks again for putting this together!

@deanmalmgren

This comment has been minimized.

Owner

deanmalmgren commented Aug 14, 2014

Addressed by #55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment