New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved subprocess API calls #114

Merged
merged 9 commits into from Nov 15, 2016

Conversation

Projects
None yet
4 participants
@pierre-ernst
Contributor

pierre-ernst commented Jun 9, 2016

Refactored the code to use recommended usage of python subprocess package.

@coveralls

This comment has been minimized.

coveralls commented Jun 20, 2016

Coverage Status

Coverage decreased (-0.1%) to 88.341% when pulling daf148f on pierre-ernst:master into 2d598ad on deanmalmgren:master.

@qsebas

This comment has been minimized.

qsebas commented Oct 5, 2016

I've found an issue ( #124 ) that is solved with this pull request.
if a word filename contains a backquote / backtick / grave accent the shell executions throws an exception.

@deanmalmgren deanmalmgren merged commit 3aff931 into deanmalmgren:master Nov 15, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@deanmalmgren

This comment has been minimized.

Owner

deanmalmgren commented Nov 15, 2016

Thank you once again for putting this together @pierre-ernst. Please accept my sincere apologies in merging this in. This looks great and will be included in the next release of textract, which I'll hopefully push out later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment