New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pillow fails installation on precise without libjpeg-dev #119

Merged
merged 1 commit into from Nov 15, 2016

Conversation

Projects
None yet
4 participants
@akoumjian
Contributor

akoumjian commented Aug 13, 2016

I'm in the process of working on a more substantial PR, but I noticed the vagrant environment failed proper setup because it was missing libjpeg-dev. Not sure if this is somehow unique to me or not (shouldn't be, since I'm building on the VM image).

So, this simply adds the package name to the debian requirements file.

@coveralls

This comment has been minimized.

coveralls commented Aug 13, 2016

Coverage Status

Coverage remained the same at 88.444% when pulling 34930e0 on akoumjian:missing_jpeg into 2d598ad on deanmalmgren:master.

@deanmalmgren

This comment has been minimized.

Owner

deanmalmgren commented Aug 15, 2016

Great catch @akoumjian! I wonder if Pillow has different requirements now than it did before or something?

Would you mind also adding libjpeg-dev to the installation instructions for Debian? From Pillow's documentation, it also looks like libjpeg can be installed on OSX with brew so it'd be great to include those instructions there.

As you saw from #117, I am sorely behind in merging PRs but I am cautiously optimistic that I'll have an opportunity to merge this in later this week.

@michaelmoliterno

This comment has been minimized.

Collaborator

michaelmoliterno commented Aug 24, 2016

@deanmalmgren I was able to reproduce the same issue as @akoumjian when spinning up Vagrant machines and the fix in this PR worked; I agree that the Debian section in docs/installation.rst should also be updated for completeness. Regarding the OSX installation, it looks like jpeg is installed via brew as a dependency for poppler (already in the docs), so I'm not sure this needs to be added unless we want to be super duper explicit.

@akoumjian

This comment has been minimized.

Contributor

akoumjian commented Aug 30, 2016

Not on my home machine but I will update the docs in this pr tonight.

@deanmalmgren

This comment has been minimized.

Owner

deanmalmgren commented Nov 15, 2016

I'll add these things to the documentation. Thanks again for putting this together.

@deanmalmgren deanmalmgren reopened this Nov 15, 2016

@deanmalmgren deanmalmgren merged commit 34930e0 into deanmalmgren:master Nov 15, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

deanmalmgren added a commit that referenced this pull request Nov 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment