New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Audio file extraction #56

Merged
merged 13 commits into from Aug 26, 2014

Conversation

Projects
None yet
3 participants
@arvindch
Contributor

arvindch commented Aug 23, 2014

Allows text/speech extraction from audio files, with SpeechRecognition
Currently supports only .wav files - more filetypes planned

@arvindch arvindch referenced this pull request Aug 23, 2014

Closed

why not audio files? #35

@deanmalmgren deanmalmgren force-pushed the deanmalmgren:master branch from df4664a to 515a12e Aug 25, 2014

@arvindch

This comment has been minimized.

Contributor

arvindch commented Aug 26, 2014

Upstream SpeechRecognition has merged my python2 compatibility PR.
Travis CI Build passes now.

@arvindch

This comment has been minimized.

Contributor

arvindch commented Aug 26, 2014

Added stuff that CONTRIBUTING.md recommends.

@deanmalmgren

This comment has been minimized.

Owner

deanmalmgren commented Aug 26, 2014

This is awesome! Thanks for adding the test and the support information to the docs. I added a couple of minor comments above that would be great to resolve before merging.

Yesterday I updated the testing framework away from this haphazard bash script to using nose. I'd be happy to convert your test to using the new framework if you'd like, but I'd appreciate any thoughts you have on the latest CONTRIBUTING.md as I want to make that as clear as possible—so its easy as possible to provide support for new file types, fix bugs, etc.

@arvindch

This comment has been minimized.

Contributor

arvindch commented Aug 26, 2014

OK, So I've added in the contributing info and changed the default text.
I'll try to convert to the new test as well, now.

arvindch added some commits Aug 23, 2014

added wav parsing, with SpeechRecognition
Signed-off-by: Arvind Chembarpu <achembarpu@gmail.com>
added .wav test file
Signed-off-by: Arvind Chembarpu <achembarpu@gmail.com>
force python2 compat versions only
Signed-off-by: Arvind Chembarpu <achembarpu@gmail.com>
added improved wav test file
Signed-off-by: Arvind Chembarpu <achembarpu@gmail.com>
added wav test case to testing script
Signed-off-by: Arvind Chembarpu <achembarpu@gmail.com>
adde wav file support to index
Signed-off-by: Arvind Chembarpu <achembarpu@gmail.com>
added contribution to changelog
Signed-off-by: Arvind Chembarpu <achembarpu@gmail.com>
changed default audio extraction text
lessens ambiguity

Signed-off-by: Arvind Chembarpu <achembarpu@gmail.com>
@deanmalmgren

This comment has been minimized.

Owner

deanmalmgren commented Aug 26, 2014

OK, great. If you have any problems I can certainly take care of it! I'm using you as a test case [yuk yuk] for whether the new testing framework is as easy as I hope it is.

@arvindch arvindch force-pushed the arvindch:audio-extraction branch from 3c5953a to d78e702 Aug 26, 2014

@arvindch

This comment has been minimized.

Contributor

arvindch commented Aug 26, 2014

I've sent you an email, via about.me - I have some questions about this.

edit - I think I'll try to code in the new testing scheme.

@coveralls

This comment has been minimized.

coveralls commented Aug 26, 2014

Coverage Status

Coverage decreased (-2.74%) when pulling d78e702 on arvindch:audio-extraction into 8ed5cfd on deanmalmgren:master.

arvindch added some commits Aug 26, 2014

added testing info to docstring
for future reference

Signed-off-by: Arvind Chembarpu <achembarpu@gmail.com>
added standardized text test for wav
Signed-off-by: Arvind Chembarpu <achembarpu@gmail.com>
created wav testcase
Signed-off-by: Arvind Chembarpu <achembarpu@gmail.com>
added raw_text test files
Signed-off-by: Arvind Chembarpu <achembarpu@gmail.com>
added flac package to system requirements
Signed-off-by: Arvind Chembarpu <achembarpu@gmail.com>
@coveralls

This comment has been minimized.

coveralls commented Aug 26, 2014

Coverage Status

Coverage increased (+0.3%) when pulling 308ebd4 on arvindch:audio-extraction into 8ed5cfd on deanmalmgren:master.

deanmalmgren added a commit that referenced this pull request Aug 26, 2014

Merge pull request #56 from arvindch/audio-extraction
Added Audio file extraction for .wav files

@deanmalmgren deanmalmgren merged commit 535a83b into deanmalmgren:master Aug 26, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@deanmalmgren

This comment has been minimized.

Owner

deanmalmgren commented Aug 26, 2014

Thanks again, @arvindch! It was fun working with you on this.

deanmalmgren added a commit that referenced this pull request Aug 26, 2014

@arvindch arvindch deleted the arvindch:audio-extraction branch Aug 26, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment