New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes paths so Docker can run. #73

Merged
merged 6 commits into from Oct 3, 2014

Conversation

Projects
None yet
3 participants
@ShawnMilo
Contributor

ShawnMilo commented Sep 6, 2014

For issue #72.

@coveralls

This comment has been minimized.

coveralls commented Sep 6, 2014

Coverage Status

Coverage remained the same when pulling ff93ae2 on ShawnMilo:master into affeb06 on deanmalmgren:master.

@deanmalmgren

This comment has been minimized.

Owner

deanmalmgren commented Sep 8, 2014

Thanks for putting this together.

After our last discussion, I'm surprised you moved the Dockerfile back into a subdirectory; any particular reason for that?

It seems that we still have some path problems, specifically in the provision/debian.sh script that are breaking the Vagrant provisioning. If you'd like, I'd be happy to hop on a google+ hangout or skype to clear this up sometime today so we can get this working in both development environments.

@coveralls

This comment has been minimized.

coveralls commented Sep 8, 2014

Coverage Status

Changes Unknown when pulling a6d7900 on ShawnMilo:master into * on deanmalmgren:master*.

@ShawnMilo

This comment has been minimized.

Contributor

ShawnMilo commented Sep 8, 2014

I put the Dockerfile back because I realized I could move during build time with a shell script. This keeps the root of the repo cleaner.

I never knew anything about Vagrant actually running the script from /tmp -- that's the root of all our problems. I just updated the script so that problem should go away in Vagrant. If that doesn't work in Vagrant then we should do a hangout and see what's up.

@ShawnMilo

This comment has been minimized.

Contributor

ShawnMilo commented Sep 8, 2014

The latest push fails, but apparently only because there's a failing test.

@deanmalmgren deanmalmgren merged commit c28225f into deanmalmgren:master Oct 3, 2014

1 check failed

continuous-integration/travis-ci The Travis CI build failed
Details
@deanmalmgren

This comment has been minimized.

Owner

deanmalmgren commented Oct 3, 2014

Really sorry for the delay in getting this merged in. Last month got rather busy with personal and work activities. Thanks again for putting this together @ShawnMilo; I think its really great that people can use Docker for development purposes!

I'm going to have to fix that test. That's rather annoying...

@ShawnMilo

This comment has been minimized.

Contributor

ShawnMilo commented Oct 3, 2014

Sweet. I'm glad to see it merged.

I was thinking that maybe we could make a Docker image in the official Docker repository so textract developers wouldn't even have to build at all.

@deanmalmgren

This comment has been minimized.

Owner

deanmalmgren commented Oct 3, 2014

That'd be cool.

One thing I've separately been thinking about, but on a related note, is
that it would be good to just have a .deb package that takes care of all
the dependencies and so forth. Have you ever done anything like that before?

dean malmgren | +1.312.884.9214 partner, data scientist | datascope

On Fri, Oct 3, 2014 at 9:50 AM, Shawn Milochik notifications@github.com
wrote:

Sweet. I'm glad to see it merged.

I was thinking that maybe we could make a Docker image in the official
Docker repository so textract developers wouldn't even have to build at
all.

Reply to this email directly or view it on GitHub
#73 (comment).

@deanmalmgren

This comment has been minimized.

Owner

deanmalmgren commented Oct 4, 2014

Now that I'm thinking about it more, the .deb package would be useful for installing, not for development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment