Skip to content

Fix the comment about the sql string interpolator #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2021
Merged

Fix the comment about the sql string interpolator #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/main/scala/progscala3/contexts/SQLStringInterpolator.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,12 @@ object SimpleSQL:
def tup2Seq(t: (String,String)): Seq[String] = Seq(t._1, t._2) // <3>
def keep(s: String): Boolean = s.length > 0 && s != "SELECT" && s != "FROM"

// It turns out that the length of the "values" passed to +sql+ will always
// be one more than the length of the "sc.parts". If we use no variables,
// "values" has one element, the whole string, and "sc.parts" is empty.
// If we use a variable for the columns, then "values" will be
// "Seq("SELECT ", "FROM")" and "sc.parts" will contain a string for columns.
// Using a variable for the table name instead will be similar, but "values"
// It turns out that the length of the "sc.parts" passed to +sql+ will always
// be one more than the length of the "values". If we use no variables,
// "sc.parts" has one element, the whole string, and "values" is empty.
// If we use a variable for the columns, then "sc.parts" will be
// "Seq("SELECT ", "FROM tableName")" and "values" will contain a string for columns.
// Using a variable for the table name instead will be similar, but "sc.parts"
// will end with an empty string. You can add print statements to see this
// in action.
// This is why these two sequences are combined with "zipAll", so we can
Expand Down