New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add precommit #4

Merged
merged 6 commits into from Aug 20, 2018

Conversation

Projects
None yet
2 participants
@deanwilson
Owner

deanwilson commented Aug 4, 2018

Add terraform precommit hooks for this repo and clean up the issues they raise.

deanwilson added some commits Aug 4, 2018

Format the terraform code to match the style guide
Indentation was wrong. It should now satisfy `terraform fmt`
which we're adopting for consistency.

There should be no functional changes
Add providers and default variables
This code base is from before providers
were extracted so add them in to the module
Replace manual docs with autogenerated ones
Add the precommit hooks and descriptions required to
autogenerate the README section that covers variables and outputs.
@netflash

/lgtm

@@ -0,0 +1,8 @@
provider "aws" {
region = "${var.aws_region}"
version = "1.30.0"

This comment has been minimized.

@netflash

This comment has been minimized.

@deanwilson

deanwilson Aug 20, 2018

Owner

Fixed. Thanks!

}
provider "template" {
version = "1.0.0"

This comment has been minimized.

@netflash

@deanwilson deanwilson merged commit e173a2e into master Aug 20, 2018

@deanwilson deanwilson deleted the add_precommit branch Aug 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment