Add more metrics of Meters and Timers to Prometheus registry #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
Meters and Timers have quite a lot of methods to acquire rates, counts and other stuff, but not all of them are published to Prometheus registry. I suppose they can be useful in certain situations, thus this PR adds missing metrics to registry as gauges.
Some of the metrics are still missing (like percentiles) - my guess is to choose a number of the most useful of them (for example, 25%, 50%, 75%, 90%, 95%, 99%) and add them as gauges as well.
Big thanks for the library, by the way :)