Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remake SET implementation #250

Merged
merged 2 commits into from Sep 7, 2019
Merged

remake SET implementation #250

merged 2 commits into from Sep 7, 2019

Conversation

@atais atais force-pushed the duration branch 2 times, most recently from e0e1d52 to 4134176 Compare September 5, 2019 20:56
@debasishg
Copy link
Owner

debasishg commented Sep 5, 2019 via email

@atais
Copy link
Author

atais commented Sep 5, 2019

@debasishg seems like a good tradeoff.

The default call (without the params) is cross-compatible.
I have managed to base old API calls on the new one, so now you can remove it on major release without any problems.

Copy link
Owner

@debasishg debasishg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@debasishg debasishg merged commit 450dd11 into debasishg:master Sep 7, 2019
@atais atais deleted the duration branch September 12, 2019 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants