Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version info in v2.1.2 is wrong #248

Closed
kakra opened this issue Feb 4, 2019 · 9 comments

Comments

@kakra
Copy link

commented Feb 4, 2019

These lines in v2.1.2 tag are wrong:

set (BARRIER_VERSION_MINOR 2)

Probably a merge glitch that slipped through...

Building this version results in the binary identifying itself as 2.2.0 while it isn't. I think this problem has also been there already in a previous version.

@AdrianKoshka

This comment has been minimized.

Copy link
Member

commented Feb 4, 2019

Yeah, forgot to update some metadata.

@yjqg6666

This comment has been minimized.

Copy link

commented May 7, 2019

so is the release version which should be 2.1.2 instead of 2.2.0.

@parkerlreed

This comment has been minimized.

Copy link

commented Jun 7, 2019

@AdrianKoshka

This comment has been minimized.

Copy link
Member

commented Jun 7, 2019

Yeah…it's not high priority and I'm on vacation right now…

@mirh

This comment has been minimized.

Copy link

commented Aug 14, 2019

This is fixed.. I guess?

@shymega

This comment has been minimized.

Copy link
Member

commented Aug 14, 2019

As of commit 8e8b38b, the version tag has been updated to 2.3.0. I can see from commit 73c13ab, the version tag is 2.2.0.

@walker0643 How can we fix this? I'd rather not rewrite the Git history, but I'm not convinced there's any other way, given the nature of Git.

@mirh

This comment has been minimized.

Copy link

commented Aug 14, 2019

... I don't know which commits you are picking up, but it seems just right here
https://github.com/debauchee/barrier/blob/v2.3.1/cmake/Version.cmake

@shymega

This comment has been minimized.

Copy link
Member

commented Aug 14, 2019

Didn't look look like it from my end.

@shymega

This comment has been minimized.

Copy link
Member

commented Aug 14, 2019

Ah.. I've just seen my repo is a few commits behind 😅 I guess we can close this issue now.

@shymega shymega closed this Aug 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.