Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmake update causes error with barrier #49

Closed
kenny-w1 opened this issue May 26, 2018 · 7 comments

Comments

@kenny-w1
Copy link

commented May 26, 2018

Operating Systems

Server: Artix

Client: Artix & Devuan

Barrier Version

snapshot, latest

Steps to reproduce bug

Try to build barrier on arch-based distro with newest cmake from pacman package manager

qt5_use_modules is apparently deprecated but its back now? I don't know how to make this build now...

-- Full Barrier version string is '2.1.0-snapshot-snapshot.b1-773a0081'
-- Configuring directory /home/user/Compiles/Barrier-fresh/src/barrier/build/rpm
-- Configuring file barrier.spec
CMake Error at src/gui/CMakeLists.txt:25 (qt5_use_modules):
Unknown CMake command "qt5_use_modules".

I'm having a hard time trying to figure out how to make this build now... :(
QT_SELECT=5 / QT_SELECT=4 doesn't seem to have any effect...

@kenny-w1

This comment has been minimized.

Copy link
Author

commented May 26, 2018

I think the problem is in the source-code of Barrier but maybe I'm wrong, I don't really know...
This is really confusing :/ I can't find any answers to this anywhere.... ugh...

@xantoz

This comment has been minimized.

Copy link

commented May 29, 2018

Do the changes in the following patch resolve it: https://gitweb.gentoo.org/repo/gentoo.git/plain/x11-misc/synergy/files/synergy-1.9.1-qt-5.11.patch?id=5dd1f7a3908dec9ae6cf6773acd8ec3b33fc0b2c

You will need to change synergy to barrier in a few places to make it apply. Alternatively, it might just be easier to apply the changes by hand.

@Tblue

This comment has been minimized.

Copy link

commented May 29, 2018

@xantoz, thanks -- the patch fixes the issue.

As a hotfix, I included the patch in the Arch Linux AUR package, see 0001-Handle-removal-of-cmake-macro-qt5_use_modules.patch. Of course, credit for the patch goes to whoever created it for Gentoo. :-)

@johnny-mac

This comment has been minimized.

Copy link

commented Jun 7, 2018

Hey Tblue how do you make it skip the integrity check for the .patch file? It keeps wanting to do an integ check only when I include the .patch file, but even when I add
md5sums=('SKIP')
sha256sums=('SKIP')
sha512sums=('SKIP')
it won't validate the integrity, even when I add the md5sums for the .patch file it still tells me:

-> Found 0001-Handle-removal-of-cmake-macro-qt5_use_modules.patch
==> ERROR: Integrity checks (md5) differ in size from the source array.

dayne added a commit to dayne/barrier that referenced this issue Jun 7, 2018

Gentoo QT5 patch by Andreas Sturmletchner: fixes debauchee#49
https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5dd1f7a3908dec9ae6cf6773acd8ec3b33fc0b2c

Gentoo's patch is distributed under the terms of the GNU General Public License v2
compatible with this project.
@Tblue

This comment has been minimized.

Copy link

commented Jun 10, 2018

@johnny-mac, as the error message suggests, each file in the source array needs to have a corresponding checksum (or the keyword SKIP) in the checksum arrays (md5sums etc.).

Try makepkg -g >> PKGBUILD to have the checksums generated automatically. You could also use my Arch Linux AUR package as a base for your own modifications. :-)

@walker0643

This comment has been minimized.

Copy link
Member

commented Jun 30, 2018

Confirmation on fix and 3 weeks since activity. Closing for now but please reopen if I'm mistaken.

@walker0643 walker0643 closed this Jun 30, 2018

walker0643 pushed a commit that referenced this issue Jun 30, 2018

@walker0643

This comment has been minimized.

Copy link
Member

commented Jun 30, 2018

I went ahead and added the patch. Seemed like a good idea ...

@Infinisil Infinisil referenced this issue Jul 1, 2018

Merged

barrier: fix compilation on Qt 5.11 #42842

3 of 9 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.