Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add key entries for Eisu_toggle and Muhenkan #818

Merged
merged 1 commit into from Aug 7, 2020

Conversation

tom-tan
Copy link

@tom-tan tom-tan commented Jul 27, 2020

This request adds key type entries for Eisu_toggle and Muhenkan, which are used in Japanese keyboards for macOS and Windows computers.
It also adds missing entry of kKeyNameMap for kKeyKana.

These keys are important for Japanese input methods that input Japanese characters from alphabets (e.g., "ひらがな" from "hiragana").

  • Henkan and Muhenkan are used to enable and disable input methods, respectively in Windows computers.
    • Henkan is already available in key_types.h and key_types.cpp
  • Kana and Eisu_toggle are used to enable and disable input methods, respectively in macOS computers.
    • Kana is already available in key_types.h but not available in key_types.cpp

This request makes easier for Japanese users to share a keyboard between Windows and macOS computers while keeping the functionality of Japanese input methods.

Note: I searched for keysyms for Eisu_toggle and Muhenkan in the following link: http://wiki.linuxquestions.org/wiki/List_of_Keysyms_Recognised_by_Xmodmap.

@shymega
Copy link

shymega commented Jul 28, 2020

Looks sane to me, approving, but going to ask @p12tic to review as well.

@shymega shymega requested review from shymega and p12tic July 28, 2020 21:11
@shymega shymega added the enhancement New feature or request label Jul 28, 2020
Copy link

@shymega shymega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me - and CI has passed, so happy to merge 👍

@tom-tan
Copy link
Author

tom-tan commented Aug 7, 2020

ping!

@p12tic
Copy link
Member

p12tic commented Aug 7, 2020

@tom-tan Many thanks for the pull request!

@p12tic p12tic merged commit 36ae769 into debauchee:master Aug 7, 2020
@tom-tan tom-tan deleted the add-eisu-muhenkan branch August 7, 2020 08:56
@amosbird
Copy link

Hmm, I've built the latest master but still cannot have Eisu_toggle mapping in
image

@tom-tan
Copy link
Author

tom-tan commented Sep 26, 2020

As I mentioned in #832, it needs extra work to work these keys in GUI editor.
You can add keystroke settings by editing configuration file directly.

See also: #840.

p12tic added a commit to p12tic/barrier that referenced this pull request Jan 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants