Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBZ-4113 Add new GH workflow for debezium-connect-rest-extension #2774

Merged
merged 2 commits into from Oct 6, 2021

Conversation

ani-sha
Copy link
Member

@ani-sha ani-sha commented Oct 6, 2021

@gunnarmorling
Copy link
Member

That's interesting; why should the extension be built as part of all these workflows? I was rather thinking of having a new workflow, triggered by changes in this module and its dependences (BOM, parent, etc.), akin to the other module-specific workflows.

@ani-sha
Copy link
Member Author

ani-sha commented Oct 6, 2021

@gunnarmorling I thought it was a dependency for rest workflows. Created a new workflow.

@ani-sha ani-sha changed the title DBZ-4113 Add debezium-connect-rest-extension module to GH workflows DBZ-4113 Add new GH workflow for debezium-connect-rest-extension Oct 6, 2021
@rk3rn3r
Copy link
Member

rk3rn3r commented Oct 6, 2021

Hey @ani-sha. My plan was to add some unit tests first with another PR for the extension and when I am on this I would've also created a test workflow. The REST extension isn't a connector so some of the applied triggers for this workflow might not be needed.
@gunnarmorling maybe I should do this with another task when adding tests next week?

@gunnarmorling
Copy link
Member

I've pushed a commit for removing some of the paths which shouldn't be needed. Let's add the workflow now, so we have it in place when you add the tests and we can see whether they pass :)

@gunnarmorling gunnarmorling merged commit f03cc49 into debezium:master Oct 6, 2021
@ani-sha ani-sha deleted the DBZ-4113 branch December 3, 2021 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants