From 243a20d3c3af2ead71d6e763cb58da82a18cd01b Mon Sep 17 00:00:00 2001 From: Maciej Delmanowski Date: Sat, 5 Oct 2019 19:19:34 +0200 Subject: [PATCH] [debops.owncloud] Switch double quotes to single This change should ensure that the strings provided by Ansible to the shell are not interpreted by the shell by mistake - for example a randomly generated password could contain a '$' character that could be interpreted as a variable name. --- ansible/roles/debops.owncloud/tasks/ldap.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ansible/roles/debops.owncloud/tasks/ldap.yml b/ansible/roles/debops.owncloud/tasks/ldap.yml index 05767723fc..e92c8fea81 100644 --- a/ansible/roles/debops.owncloud/tasks/ldap.yml +++ b/ansible/roles/debops.owncloud/tasks/ldap.yml @@ -33,7 +33,7 @@ when: owncloud__register_local_facts_ldap is changed - name: Configure LDAP parameters - command: php --file "{{ owncloud__app_home }}/occ" ldap:set-config "{{ owncloud__ldap_config_id }}" "{{ item.name }}" "{{ item.value }}" + command: php --file '{{ owncloud__app_home }}/occ' ldap:set-config '{{ owncloud__ldap_config_id }}' '{{ item.name }}' '{{ item.value }}' changed_when: False become: True become_user: '{{ owncloud__app_user }}'