/ debug Public
Whitelist DEBUG_FD for values 1 and 2 only Fixes #410 #415
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
UPDATED: Please see discussion below
This PR tries to smartly hide DEBUG_FD deprecation annoying warning if this conditions are met:
DEBUG_COLORSenv variable is detected (webstorm uses that)
DEBUG_FDis set to 1 (default value by web-storm & idea)
So if user customizes
DEBUG_FDto something other than 1 she will still get the notification but this saves majority of other users
As discussed in #410 Also Here and Here after
DEBUG_FDis deprecated many & many end users who actually don't even use
DEBUG_FDvariable are affected (including all express& react-native users). This issue will not be resolved at lease next idea release (end of march) also if it resolves in that way webstorm users will totally lose error colors!