Named expression-style classes should assign that name to their scope #867

alangpierce · 2017-02-25T23:56:17Z

decaffeinate is producing the wrong JavaScript based on my CoffeeScript input:

A = class B
console.log(B)

(repl)

I get this output:

const A = class B {};
console.log(B);

Here's what I expect it to be instead:

let B;
const A = B = class B {};
console.log(B);

This is causing the atom tests to fail after decaffeinate.

Fixes decaffeinate#867 Unlike in JavaScript, CoffeeScript named classes assign to their outer scope, so we need an explicit assignment unless we know the class will be a JS class declaration statement.

Fixes #867 Unlike in JavaScript, CoffeeScript named classes assign to their outer scope, so we need an explicit assignment unless we know the class will be a JS class declaration statement.

alangpierce added the incorrect-output label Feb 25, 2017

alangpierce self-assigned this Feb 25, 2017

alangpierce mentioned this issue Feb 26, 2017

fix: always generate an assignment for expression-style classes #868

Merged

alangpierce closed this as completed in #868 Feb 26, 2017

Named expression-style classes should assign that name to their scope #867

Named expression-style classes should assign that name to their scope #867

Comments

alangpierce commented Feb 25, 2017